hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-27 01:35:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

Swift: Remove the code related to constructor capture (and the related TODO). This cannot happen in Swift.

Browse Source
This commit is contained in:
Mathias Vorreiter Pedersen
2023-10-27 11:05:48 +01:00
parent 65e13aa5ed
commit b41ec37993
1 changed files with 24 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
swift/ql/lib/codeql/swift/dataflow/internal/DataFlowPrivate.qll
View File

@@ -942,7 +942,30 @@ private module CaptureInput implements VariableCapture::InputSig {
}
class Callable extends S::Callable {
predicate isConstructor() { this instanceof S::Initializer }
predicate isConstructor() {
// A class declaration cannot capture a variable in Swift. Consider this hypothetical example:
// ```
// protocol Interface { }
// func foo() -> Interface {
// let y = 42
// class Impl : Interface {
// let x : Int
// init() {
// x = y
// }
// }
// let object = Impl()
// return object
// }
// ```
// The Swift compiler will reject this with an error message such as
// ```
// error: class declaration cannot close over value 'y' defined in outer scope
// x = y
// ^
// ```
none()
}
}
}
@@ -964,8 +987,6 @@ private CaptureFlow::ClosureNode asClosureNode(Node n) {
or
result.(CaptureFlow::ThisParameterNode).getCallable() = n.(ClosureSelfParameterNode).getClosure()
or
result.(CaptureFlow::MallocNode).getClosureExpr() = n.getCfgNode().getNode().asAstNode() // TODO: figure out why the java version had PostUpdateNode logic here
or
exists(CaptureInput::VariableWrite write |
result.(CaptureFlow::VariableWriteSourceNode).getVariableWrite() = write and
n.asExpr() = write.getSource()