hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-25 00:27:09 +02:00
Code Issues Packages Projects Releases Wiki Activity

PS: Drive-by performance fix: Don't generate N store steps when storing into an unknown index.

Browse Source
This commit is contained in:
Mathias Vorreiter Pedersen
2024-10-14 16:19:57 +01:00
parent 01a556e583
commit b2225fe7b5
1 changed files with 16 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
powershell/ql/lib/semmle/code/powershell/dataflow/internal/DataFlowPrivate.qll
View File

@@ -667,19 +667,19 @@ predicate storeStep(Node node1, ContentSet c, Node node2) {
c.isSingleton(fc)
)
or
exists(
CfgNodes::ExprNodes::IndexCfgWriteNode var, Content::KnownElementContent ec, int index,
CfgNodes::ExprCfgNode e
|
exists(CfgNodes::ExprNodes::IndexCfgWriteNode var, CfgNodes::ExprCfgNode e |
node2.(PostUpdateNode).getPreUpdateNode().asExpr() = var.getBase() and
node1.asStmt() = var.getAssignStmt().getRightHandSide() and
c.isKnownOrUnknownElement(ec) and
index = ec.getIndex().asInt() and
e = var.getIndex()
|
index = e.getValue().asInt()
exists(int index, Content::KnownElementContent ec |
c.isKnownOrUnknownElement(ec) and
index = ec.getIndex().asInt() and
index = e.getValue().asInt()
)
or
not exists(e.getValue().asInt())
not exists(e.getValue().asInt()) and
c.isAnyElement()
)
or
exists(Content::KnownElementContent ec, int index |
@@ -712,19 +712,19 @@ predicate readStep(Node node1, ContentSet c, Node node2) {
c.isSingleton(fc)
)
or
exists(
CfgNodes::ExprNodes::IndexCfgReadNode var, Content::KnownElementContent ec, int index,
CfgNodes::ExprCfgNode e
|
exists(CfgNodes::ExprNodes::IndexCfgReadNode var, CfgNodes::ExprCfgNode e |
node2.asExpr() = var and
node1.asExpr() = var.getBase() and
c.isKnownOrUnknownElement(ec) and
index = ec.getIndex().asInt() and
e = var.getIndex()
|
index = e.getValue().asInt()
exists(int index, Content::KnownElementContent ec |
c.isKnownOrUnknownElement(ec) and
index = ec.getIndex().asInt() and
index = e.getValue().asInt()
)
or
not exists(e.getValue().asInt())
not exists(e.getValue().asInt()) and
c.isAnyElement()
)
or
exists(CfgNode cfgNode |