hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-25 16:55:19 +02:00
Code Issues Packages Projects Releases Wiki Activity

UniversalFlow: Skip property propagation to null nodes.

Browse Source
This commit is contained in:
Anders Schack-Mulligen
2024-10-30 14:08:38 +01:00
parent 1d3bad1358
commit b005973317
1 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
shared/typeflow/codeql/typeflow/UniversalFlow.qll
View File

@@ -87,6 +87,10 @@ module Make<LocationSig Location, UniversalFlowInput<Location> I> {
)
}
private predicate uniqStepNotNull(FlowNode n1, FlowNode n2) {
uniqStep(n1, n2) and not isNull(n1)
}
private import Internal
module Internal {
@@ -100,7 +104,9 @@ module Make<LocationSig Location, UniversalFlowInput<Location> I> {
* Holds if data can flow from `n1` to `n2` in one step, excluding join
* steps from nodes that are always null.
*/
predicate anyStep(FlowNode n1, FlowNode n2) { joinStepNotNull(n1, n2) or uniqStep(n1, n2) }
predicate anyStep(FlowNode n1, FlowNode n2) {
joinStepNotNull(n1, n2) or uniqStepNotNull(n1, n2)
}
}
private predicate sccEdge(FlowNode n1, FlowNode n2) { anyStep(n1, n2) and anyStep+(n2, n1) }
@@ -250,7 +256,7 @@ module Make<LocationSig Location, UniversalFlowInput<Location> I> {
or
not P::barrier(n) and
(
exists(FlowNode mid | hasProperty(mid) and uniqStep(mid, n))
exists(FlowNode mid | hasProperty(mid) and uniqStepNotNull(mid, n))
or
// The following is an optimized version of
// `forex(FlowNode mid | joinStepNotNull(mid, n) | hasPropery(mid))`
@@ -298,7 +304,7 @@ module Make<LocationSig Location, UniversalFlowInput<Location> I> {
or
not P::barrier(n) and
(
exists(FlowNode mid | hasProperty(mid, t) and uniqStep(mid, n))
exists(FlowNode mid | hasProperty(mid, t) and uniqStepNotNull(mid, n))
or
// The following is an optimized version of
// `forex(FlowNode mid | joinStepNotNull(mid, n) | hasPropery(mid, t))`