hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-02-08 11:11:06 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #62 from github/if-with-none

Browse Source 
QL: Add query that finds 'if p() then q() else none()'
This commit is contained in:
Mathias Vorreiter Pedersen
2021-10-13 14:29:15 +01:00
committed by GitHub
parent b8d26abbc2 c3f9d584a4
commit aef394e2d1
1 changed files with 15 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
ql/src/queries/style/IfWithElseNone.ql Normal file
View File

@@ -0,0 +1,15 @@
/**
* @name Use of 'if' with a 'none()' branch.
* @description Using 'if p() then q() else none()' is bad style. It should be rewritten as 'p() and q()'.
* @kind problem
* @problem.severity warning
* @id ql/if-with-none
* @precision very-high
* @tags maintainability
*/
import ql
from IfFormula ifFormula
where ifFormula.getElsePart() instanceof NoneCall or ifFormula.getThenPart() instanceof NoneCall
select ifFormula, "Use a conjunction instead."