hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-18 01:33:15 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #145 from nickrolfe/rewording

Browse Source 
C++: clearer alert wording in integer-multiplication-cast-to-long
This commit is contained in:
Geoffrey White
2018-09-04 18:00:37 +01:00
committed by GitHub
parent 98aa7f88b2 f2d030a7e6
commit ae80b8dbec
2 changed files with 10 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
cpp/ql/src/Likely Bugs/Arithmetic/IntMultToLong.ql
View File

@@ -103,4 +103,4 @@ where t1 = me.getType().getUnderlyingType() and
) and
e.(Literal).getType().getSize() = t2.getSize()
)
select me, "Cast to '" + me.getFullyConverted().getType().toString() + "' before multiplication to avoid potential overflow."
select me, "Multiplication result may overflow '" + me.getType().toString() + "' before it is converted to '" + me.getFullyConverted().getType().toString() + "'."