hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-17 01:03:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #121 from hvitved/csharp/sync-test-files

Browse Source 
C#: Synchronize a few test files
This commit is contained in:
calumgrant
2018-09-04 15:01:19 +01:00
committed by GitHub
parent cbca1e1105 809da42f00
commit 98aa7f88b2
7 changed files with 13 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
csharp/ql/src/API Abuse/IncorrectEqualsSignatureBad.cs
View File

@@ -1,3 +1,5 @@
using System;
class Bad
{
private int id;

4
csharp/ql/src/API Abuse/IncorrectEqualsSignatureGood.cs
View File

@@ -1,3 +1,5 @@
using System;
class Good
{
private int id;
@@ -12,7 +14,7 @@ class Good
public override bool Equals(object o)
{
if (o is Good g && g.GetType() = typeof(Good))
if (o is Good g && g.GetType() == typeof(Good))
return this.Equals(g);
return false;
}

2
csharp/ql/src/Security Features/CWE-022/ZipSlipGood.cs
View File

@@ -14,4 +14,4 @@ class Good
}
entry.ExtractToFile(destFileName);
}
}
}

8
csharp/ql/src/Security Features/CWE-327/DontInstallRootCert.ql
View File

@@ -13,14 +13,14 @@ import semmle.code.csharp.dataflow.DataFlow::DataFlow
class AddCertToRootStoreConfig extends DataFlow::Configuration {
AddCertToRootStoreConfig() { this = "Adding Certificate To Root Store" }
override predicate isSource(DataFlow::Node source) {
exists(ObjectCreation oc | oc = source.asExpr() |
override predicate isSource(DataFlow::Node source) {
exists(ObjectCreation oc | oc = source.asExpr() |
oc.getType().(RefType).hasQualifiedName("System.Security.Cryptography.X509Certificates.X509Store") and
oc.getArgument(0).(Access).getTarget().hasName("Root")
)
}
override predicate isSink(DataFlow::Node sink) {
exists(MethodCall mc |
(mc.getTarget().hasQualifiedName("System.Security.Cryptography.X509Certificates.X509Store", "Add") or

1
csharp/ql/test/query-tests/Architecture/Dependencies/MutualDependency/ExtractorOptions.cs Normal file
View File

@@ -0,0 +1 @@
// semmle-extractor-options: /r:System.Linq.dll

2
csharp/ql/test/query-tests/Architecture/Dependencies/MutualDependency/MutualDependencyGood.cs
View File

@@ -42,5 +42,3 @@ public class Good
}
}
}
// semmle-extractor-options: /r:System.Linq.dll

4
csharp/ql/test/query-tests/Security Features/CWE-327/DontInstallRootCert/Test.cs
View File

@@ -65,8 +65,8 @@ namespace RootCert
{
string file1 = "mytest1.pfx"; // Contains name of certificate file
string file2 = "mytest2.pfx"; // Contains name of certificate file
var certCollection = new X509Certificate2[] {
new X509Certificate2(X509Certificate2.CreateFromCertFile(file1)),
var certCollection = new X509Certificate2[] {
new X509Certificate2(X509Certificate2.CreateFromCertFile(file1)),
new X509Certificate2(X509Certificate2.CreateFromCertFile(file2)),
};
X509Store store = new X509Store(StoreName.Root, StoreLocation.CurrentUser);