hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-17 01:03:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

Java: Address review comments.

Browse Source
This commit is contained in:
Anders Schack-Mulligen
2022-10-13 14:55:55 +02:00
parent 30a891c2e7
commit ad8f0fc1dd
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
java/ql/lib/semmle/code/java/dataflow/FlowSummary.qll
View File

@@ -99,8 +99,8 @@ private newtype TSummarizedCallableBase =
TSyntheticCallable(SyntheticCallable c)
/**
* A callable with a flow summary. This is either a regular `Callable` or a
* `SyntheticCallable`.
* A callable that may have a flow summary. This is either a regular `Callable`
* or a `SyntheticCallable`.
*/
class SummarizedCallableBase extends TSummarizedCallableBase {
/** Gets a textual representation of this callable. */
@@ -149,9 +149,9 @@ class SummarizedCallableBase extends TSummarizedCallableBase {
Type getReturnType() {
result = this.asCallable().getReturnType()
or
result = this.asSyntheticCallable().getReturnType()
or
exists(SyntheticCallable sc | sc = this.asSyntheticCallable() |
result = sc.getReturnType()
or
not exists(sc.getReturnType()) and
result instanceof TypeObject
)
@@ -161,10 +161,10 @@ class SummarizedCallableBase extends TSummarizedCallableBase {
class SummarizedCallable = Impl::Public::SummarizedCallable;
/**
* An adaptor class to add the flow summaries specified on `SyntheticCallable`
* An adapter class to add the flow summaries specified on `SyntheticCallable`
* to `SummarizedCallable`.
*/
private class SummarizedSyntheticCallableAdaptor extends SummarizedCallable, TSyntheticCallable {
private class SummarizedSyntheticCallableAdapter extends SummarizedCallable, TSyntheticCallable {
override predicate propagatesFlow(
SummaryComponentStack input, SummaryComponentStack output, boolean preservesValue
) {