hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-16 16:53:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

JS: Make 'typeStrongerThan' transitive

Browse Source
This commit is contained in:
Asger F
2025-02-18 16:03:00 +01:00
parent e40ee821c2
commit ad4522c781
1 changed files with 3 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
javascript/ql/lib/semmle/javascript/dataflow/internal/DataFlowPrivate.qll
View File

@@ -583,19 +583,14 @@ class DataFlowType extends TDataFlowType {
DataFlow::ClassNode asInstanceOfClass() { this = TInstanceType(result) }
}
private predicate typeStrongerThan1(DataFlowType t1, DataFlowType t2) {
// 't1' is a subclass of 't2'
t1.asInstanceOfClass() = t2.asInstanceOfClass().getADirectSubClass()
}
/**
* Holds if `t1` is strictly stronger than `t2`.
*/
predicate typeStrongerThan(DataFlowType t1, DataFlowType t2) {
typeStrongerThan1(t1, t2)
// 't1' is a subclass of 't2'
t1.asInstanceOfClass() = t2.asInstanceOfClass().getADirectSubClass+()
or
// Ensure all types are transitively stronger than 'any'
not typeStrongerThan1(t1, _) and
// Ensure all types are stronger than 'any'
not t1 = TAnyType() and
t2 = TAnyType()
}