hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-27 01:35:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

Address comments

Browse Source
This commit is contained in:
Arthur Baars
2020-12-21 10:52:42 +01:00
parent 8469bd3688
commit ad1782b620
2 changed files with 7 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
ql/src/codeql_ruby/ast/Variable.qll
View File

@@ -53,14 +53,14 @@ class Variable extends TVariable {
}
/** A local variable. */
class LocalVariable extends Variable {
class LocalVariable extends Variable, TLocalVariable {
override LocalVariable::Range range;
final override LocalVariableAccess getAnAccess() { result.getVariable() = this }
}
/** A global variable. */
class GlobalVariable extends Variable {
class GlobalVariable extends Variable, TGlobalVariable {
override GlobalVariable::Range range;
final override GlobalVariableAccess getAnAccess() { result.getVariable() = this }

13
ql/src/codeql_ruby/ast/internal/Variable.qll
View File

@@ -111,9 +111,7 @@ private module Cached {
cached
newtype TVariable =
TGlobalVariable(TGlobalScope scope, string name) {
name = any(Generated::GlobalVariable var).getValue()
} or
TGlobalVariable(string name) { name = any(Generated::GlobalVariable var).getValue() } or
TLocalVariable(VariableScope scope, string name, Generated::Identifier i) {
scopeDefinesParameterVariable(scope, name, i)
or
@@ -223,7 +221,7 @@ module Variable {
}
module LocalVariable {
class Range extends Variable::Range {
class Range extends Variable::Range, TLocalVariable {
private VariableScope scope;
private string name;
private Generated::Identifier i;
@@ -239,17 +237,16 @@ module LocalVariable {
}
module GlobalVariable {
class Range extends Variable::Range {
private VariableScope scope;
class Range extends Variable::Range, TGlobalVariable {
private string name;
Range() { this = TGlobalVariable(scope, name) }
Range() { this = TGlobalVariable(name) }
final override string getName() { result = name }
final override Location getLocation() { none() }
final override VariableScope getDeclaringScope() { result = scope }
final override VariableScope getDeclaringScope() { result = TGlobalScope() }
}
}