hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-21 23:14:03 +02:00
Code Issues Packages Projects Releases Wiki Activity

Rust: Refactor PathMention as suggested in review

Browse Source
This commit is contained in:
Simon Friis Vindum
2025-04-07 12:50:31 +02:00
parent a1d36c0501
commit acc565f84e
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
rust/ql/lib/codeql/rust/internal/TypeMention.qll
View File

@@ -62,18 +62,22 @@ class TypeReprMention extends TypeMention, TypeRepr {
}
}
/** Holds if `path` resolves the type alias `alias` with the definition `rhs`. */
/** Holds if `path` resolves to the type alias `alias` with the definition `rhs`. */
private predicate resolvePathAlias(Path path, TypeAlias alias, TypeReprMention rhs) {
alias = resolvePath(path) and rhs = alias.getTypeRepr()
}
abstract class PathMention extends TypeMention, Path { }
abstract class PathMention extends TypeMention, Path {
override TypeMention getTypeArgument(int i) {
result = this.getSegment().getGenericArgList().getTypeArg(i)
}
}
class NonAliasPathMention extends PathMention {
NonAliasPathMention() { not resolvePathAlias(this, _, _) }
override TypeMention getTypeArgument(int i) {
result = this.getSegment().getGenericArgList().getTypeArg(i)
result = super.getTypeArgument(i)
or
// `Self` paths inside `impl` blocks have implicit type arguments that are
// the type parameters of the `impl` block. For example, in
@@ -120,10 +124,6 @@ class AliasPathMention extends PathMention {
AliasPathMention() { resolvePathAlias(this, alias, rhs) }
override TypeMention getTypeArgument(int i) {
result = this.getSegment().getGenericArgList().getTypeArg(i)
}
/** Get the `i`th type parameter of the alias itself. */
private TypeParameter getTypeParameter(int i) {
result = TTypeParamTypeParameter(alias.getGenericParamList().getTypeParam(i))