hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-27 17:55:19 +02:00
Code Issues Packages Projects Releases Wiki Activity

C#: Rename isComplete() to isFullyConstructed()

Browse Source
This commit is contained in:
Tom Hvitved
2020-08-18 13:38:46 +02:00
parent dcccdee227
commit acb08287ab
2 changed files with 12 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
csharp/ql/src/semmle/code/csharp/Implements.qll
View File

@@ -259,7 +259,7 @@ private module Gvn {
private newtype TGvnType =
TLeafGvnType(LeafType t) or
TMethodTypeParameterGvnType(int i) { i = any(MethodTypeParameter p).getIndex() } or
TConstructedGvnType(ConstructedGvnTypeList l) { l.isComplete() }
TConstructedGvnType(ConstructedGvnTypeList l) { l.isFullyConstructed() }
private newtype TConstructedGvnTypeList =
TConstructedGvnTypeNil(Unification::CompoundTypeKind k) or
@@ -334,7 +334,9 @@ private module Gvn {
)
}
predicate isComplete() { this.getKind().getNumberOfTypeParameters() - 1 = this.length() }
predicate isFullyConstructed() {
this.getKind().getNumberOfTypeParameters() - 1 = this.length()
}
private GvnType getArg(int i) {
exists(GvnType head, ConstructedGvnTypeList tail |
@@ -365,7 +367,7 @@ private module Gvn {
*/
language[monotonicAggregates]
private string toStringConstructedPart(int i, int j) {
this.isComplete() and
this.isFullyConstructed() and
exists(Unification::GenericType t |
t = this.getConstructedGenericDeclaringTypeAt(i) and
exists(int offset, int children, string name |
@@ -398,7 +400,7 @@ private module Gvn {
language[monotonicAggregates]
string toString() {
this.isComplete() and
this.isFullyConstructed() and
exists(Unification::CompoundTypeKind k | k = this.getKind() |
result = k.toStringBuiltin(this.getArg(0).toString())
or

10
csharp/ql/src/semmle/code/csharp/Unification.qll
View File

@@ -213,7 +213,9 @@ module Gvn {
)
}
predicate isComplete() { this.getKind().getNumberOfTypeParameters() - 1 = this.length() }
predicate isFullyConstructed() {
this.getKind().getNumberOfTypeParameters() - 1 = this.length()
}
GvnType getArg(int i) {
exists(GvnType head, ConstructedGvnTypeList tail |
@@ -244,7 +246,7 @@ module Gvn {
*/
language[monotonicAggregates]
private string toStringConstructedPart(int i, int j) {
this.isComplete() and
this.isFullyConstructed() and
exists(GenericType t |
t = this.getConstructedGenericDeclaringTypeAt(i) and
exists(int offset, int children, string name |
@@ -277,7 +279,7 @@ module Gvn {
language[monotonicAggregates]
string toString() {
this.isComplete() and
this.isFullyConstructed() and
exists(CompoundTypeKind k | k = this.getKind() |
result = k.toStringBuiltin(this.getArg(0).toString())
or
@@ -509,7 +511,7 @@ module Gvn {
newtype TGvnType =
TLeafGvnType(LeafType t) or
TTypeParameterGvnType() or
TConstructedGvnType(ConstructedGvnTypeList l) { l.isComplete() }
TConstructedGvnType(ConstructedGvnTypeList l) { l.isFullyConstructed() }
cached
newtype TConstructedGvnTypeList =