hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 19:26:02 +02:00
Code Issues Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse Source 
Co-authored-by: Erik Krogh Kristensen <erik-krogh@github.com>
This commit is contained in:
Tony Torralba
2022-12-21 14:09:53 +01:00
parent 227e099854
commit ac0c42c5c6
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
ql/ql/src/queries/style/OmittableExists.ql
View File

@@ -15,7 +15,7 @@ where
existsArgument = any(Exists e).getAnArgument() and
use = unique( | | existsArgument.getAnAccess()) and
exists(Call c, int argPos | c.getArgument(argPos) = use |
not existsArgument.getType().getASuperType+() = c.getTarget().getParameterType(argPos)
existsArgument.getType() = c.getTarget().getParameterType(argPos).getASuperType*()
)
select existsArgument, "This exists argument can be omitted by using a don't-care expression $@.",
select existsArgument, "This exists variable can be omitted by using a don't-care expression $@.",
use, "in this argument"

2
ql/ql/test/queries/style/OmittableExists/OmittableExists.expected
View File

@@ -1 +1 @@
| Test.qll:10:10:10:14 | i | This exists argument can be omitted by using a don't-care expression $@. | Test.qll:10:29:10:29 | i | in this argument |
| Test.qll:10:10:10:14 | i | This exists variable can be omitted by using a don't-care expression $@. | Test.qll:10:29:10:29 | i | in this argument |