hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 11:15:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

Address review comments

Browse Source
This commit is contained in:
Owen Mansel-Chan
2022-11-15 13:36:48 +00:00
parent 166a3688f8
commit ab15a19028
2 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
go/ql/lib/semmle/go/dataflow/internal/DataFlowPrivate.qll
View File

@@ -192,7 +192,9 @@ predicate clearsContent(Node n, Content c) {
* Holds if the value that is being tracked is expected to be stored inside content `c`
* at node `n`.
*/
predicate expectsContent(Node n, ContentSet c) { none() }
predicate expectsContent(Node n, ContentSet c) {
FlowSummaryImpl::Private::Steps::summaryExpectsContent(n, c)
}
/** Gets the type of `n` used for type pruning. */
DataFlowType getNodeType(Node n) {

4
go/ql/lib/semmle/go/dataflow/internal/FlowSummaryImplSpecific.qll
View File

@@ -61,7 +61,9 @@ DataFlowType getCallbackReturnType(DataFlowType t, ReturnKind rk) { none() }
* `input`, output specification `output`, kind `kind`, and a flag `generated`
* stating whether the summary is autogenerated.
*/
predicate summaryElement(Callable c, string input, string output, string kind, boolean generated) {
predicate summaryElement(
SummarizedCallableBase c, string input, string output, string kind, boolean generated
) {
exists(
string namespace, string type, boolean subtypes, string name, string signature, string ext
|