hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-27 01:35:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix FP for always-locked fields

Browse Source
This commit is contained in:
Owen Mansel-Chan
2025-03-13 15:03:32 +00:00
parent dc2cbf7402
commit a8e993c942
2 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
java/ql/src/Security/CWE/CWE-367/TOCTOURace.ql
View File

@@ -68,7 +68,9 @@ predicate alwaysLocked(Field f) {
or
exists(RefType thisType |
forex(VarAccess access |
access = f.getAnAccess() and not access.getEnclosingCallable() instanceof InitializerMethod
access = f.getAnAccess() and
not access.getEnclosingCallable() instanceof Constructor and
not access.getEnclosingCallable() instanceof InitializerMethod
|
locallySynchronizedOnThis(access, thisType)
)

4
java/ql/test/query-tests/security/CWE-367/semmle/tests/FieldAlwaysLocked.java
View File

@@ -14,10 +14,10 @@ class FieldAlwaysLocked {
protected synchronized void checkOut() {
Object o;
if (field.size() > 0) {
Enumeration e = field.keys(); // $ SPURIOUS: Alert
Enumeration e = field.keys();
while (e.hasMoreElements()) {
o = e.nextElement();
field.remove(o); // $ SPURIOUS: Alert
field.remove(o);
}
}
}