hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-20 14:34:04 +02:00
Code Issues Packages Projects Releases Wiki Activity

Correct ReplaceAll params

Browse Source 
ReplaceAll doesn't take a count argument
This commit is contained in:
Chris Smowton
2023-09-20 10:00:53 +01:00
committed by GitHub
parent 11218f79c6
commit a8afa05b1d
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
go/ql/src/Security/CWE-117/LogInjectionGood.go
View File

@@ -9,7 +9,7 @@ import (
// GOOD: The user-provided value is escaped before being written to the log.
func handlerGood(req *http.Request) {
username := req.URL.Query()["username"][0]
escapedUsername := strings.ReplaceAll(username, "\n", "", -1)
escapedUsername = strings.ReplaceAll(escapedUsername, "\r", "", -1)
escapedUsername := strings.ReplaceAll(username, "\n", "")
escapedUsername = strings.ReplaceAll(escapedUsername, "\r", "")
log.Printf("user %s logged in.\n", escapedUsername)
}