hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 11:15:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

C#: Improve performance by mapping directly from entities to labels.

Browse Source
This commit is contained in:
calum
2018-12-04 14:51:10 +00:00
parent 595634126f
commit a7cdf528dd
1 changed files with 22 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

54
csharp/extractor/Semmle.Extraction/Context.cs
View File

@@ -50,20 +50,30 @@ namespace Semmle.Extraction
/// <returns><code>true</code> iff the label already existed.</returns>
public bool GetOrAddCachedLabel(ICachedEntity entity)
{
var id = GetId(entity);
if (id == null)
throw new InternalError("Attempt to create a null entity for {0}", entity.GetType());
Label existingLabel;
if (labelCache.TryGetValue(id, out existingLabel))
// Look up the label in the entityLabelCache
if (entityLabelCache.TryGetValue(entity, out Label label))
{
entity.Label = existingLabel;
entity.Label = label;
return true;
}
entity.Label = new Label(NewId());
DefineLabel(entity.Label, id);
labelCache[id] = entity.Label;
var id = entity.Id;
if (id == null)
throw new InternalError("Attempt to create a null entity for {0}", entity.GetType());
// Look up the Id in the idLabelCache
if (idLabelCache.TryGetValue(id, out label))
{
entity.Label = label;
entityLabelCache[entity] = label;
return true;
}
entity.Label = label = new Label(NewId());
DefineLabel(label, id);
entityLabelCache[entity] = label;
idLabelCache[id] = label;
return false;
}
@@ -90,25 +100,6 @@ namespace Semmle.Extraction
}
}
/// <summary>
/// Gets the ID belonging to cached entity <paramref name="entity"/>.
///
/// The ID itself is also cached, but unlike the label cache (which is used
/// to prevent reextraction/infinite loops), this is a pure performance
/// optimization. Moreover, the label cache is injective, which the ID cache
/// need not be.
/// </summary>
IId GetId(ICachedEntity entity)
{
IId id;
if (!idCache.TryGetValue(entity, out id))
{
id = entity.Id;
idCache[entity] = id;
}
return id;
}
/// <summary>
/// Creates a fresh label with ID "*", and set it on the
/// supplied <paramref name="entity"/> object.
@@ -120,7 +111,8 @@ namespace Semmle.Extraction
entity.Label = label;
}
readonly Dictionary<IId, Label> labelCache = new Dictionary<IId, Label>();
readonly Dictionary<IId, Label> idLabelCache = new Dictionary<IId, Label>();
readonly Dictionary<ICachedEntity, Label> entityLabelCache = new Dictionary<ICachedEntity, Label>();
readonly HashSet<Label> extractedGenerics = new HashSet<Label>();
public void DefineLabel(IEntity entity)
@@ -134,8 +126,6 @@ namespace Semmle.Extraction
TrapWriter.Emit(new DefineLabelEmitter(label, id));
}
readonly Dictionary<object, IId> idCache = new Dictionary<object, IId>();
/// <summary>
/// Queue of items to populate later.
/// The only reason for this is so that the call stack does not