hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 11:15:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #3767 from esbena/js/console-member-calls

Browse Source 
Approved by erik-krogh
This commit is contained in:
semmle-qlci
2020-06-24 08:03:49 +01:00
committed by GitHub
parent afcc6ac712 2d32ee7448
commit a723ac0d8e
3 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
javascript/ql/src/semmle/javascript/frameworks/Logging.qll
View File

@@ -54,7 +54,7 @@ private module Console {
name = getAStandardLoggerMethodName() or
name = "assert"
) and
this = console().getAMethodCall(name)
this = console().getAMemberCall(name)
}
override DataFlow::Node getAMessageComponent() {

2
javascript/ql/test/library-tests/frameworks/Logging/LoggerCall.expected
View File

@@ -15,3 +15,5 @@
| tst.js:14:1:14:48 | require ... ", arg) | tst.js:14:45:14:47 | arg |
| tst.js:16:1:16:35 | console ... ", arg) | tst.js:16:22:16:29 | "msg %s" |
| tst.js:16:1:16:35 | console ... ", arg) | tst.js:16:32:16:34 | arg |
| tst.js:19:1:19:18 | log("msg %s", arg) | tst.js:19:5:19:12 | "msg %s" |
| tst.js:19:1:19:18 | log("msg %s", arg) | tst.js:19:15:19:17 | arg |

3
javascript/ql/test/library-tests/frameworks/Logging/tst.js
View File

@@ -14,3 +14,6 @@ require("winston").createLogger().info("msg %s", arg);
require("log4js").getLogger().log("msg %s", arg);
console.assert(true, "msg %s", arg);
let log = console.log;
log("msg %s", arg);