hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-01-29 22:32:58 +01:00
Code Issues Packages Projects Releases Wiki Activity

Remove distinct between package paths for v1 and v2

Browse Source
This commit is contained in:
Owen Mansel-Chan
2021-01-14 15:41:13 +00:00
parent b5dfef894b
commit a6b5e8b1db
1 changed files with 16 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
ql/src/semmle/go/frameworks/Couchbase.qll
View File

@@ -8,20 +8,18 @@ import go
* Provides models of commonly used functions in the official Couchbase Go SDK library.
*/
module Couchbase {
/** Gets a package name for v1 of the official Couchbase Go SDK library. */
string packagePathV1() { result = modulePath() + ["/", "."] + "v1" }
/** Gets a package name for v2 of the official Couchbase Go SDK library. */
string packagePathV2() {
result = modulePath() or
result = modulePath() + ["/", "."] + "v2"
}
/** Gets a module path for the official Couchbase Go SDK library. */
private string modulePath() {
result in [
"gopkg.in/couchbase/gocb", "github.com/couchbase/gocb", "github.com/couchbaselabs/gocb"
]
/**
* Gets a package path for the official Couchbase Go SDK library.
*
* Note that v1 and v2 have different APIs, but the names are disjoint so there is no need to
* distinguish between them.
*/
bindingset[result]
string packagePath() {
result =
package([
"gopkg.in/couchbase/gocb", "github.com/couchbase/gocb", "github.com/couchbaselabs/gocb"
], "")
}
/**
@@ -42,7 +40,7 @@ module Couchbase {
"Profile", "ReadOnly", "ScanCap", "Timeout"
]
|
this.hasQualifiedName(packagePathV1(), queryTypeName, methodName)
this.hasQualifiedName(packagePath(), queryTypeName, methodName)
)
}
@@ -53,7 +51,7 @@ module Couchbase {
private class QueryFromN1qlStatementV1 extends TaintTracking::FunctionModel {
QueryFromN1qlStatementV1() {
this.hasQualifiedName(packagePathV1(), ["NewAnalyticsQuery", "NewN1qlQuery"])
this.hasQualifiedName(packagePath(), ["NewAnalyticsQuery", "NewN1qlQuery"])
}
override predicate hasTaintFlow(FunctionInput inp, FunctionOutput outp) {
@@ -74,7 +72,7 @@ module Couchbase {
exists(Method meth, string structName, string methodName |
structName in ["Bucket", "Cluster"] and
methodName in ["ExecuteN1qlQuery", "ExecuteAnalyticsQuery"] and
meth.hasQualifiedName(packagePathV1(), structName, methodName) and
meth.hasQualifiedName(packagePath(), structName, methodName) and
this = meth.getACall().getArgument(0)
)
}
@@ -93,7 +91,7 @@ module Couchbase {
exists(Method meth, string structName, string methodName |
structName in ["Cluster", "Scope"] and
methodName in ["AnalyticsQuery", "Query"] and
meth.hasQualifiedName(packagePathV2(), structName, methodName) and
meth.hasQualifiedName(packagePath(), structName, methodName) and
this = meth.getACall().getArgument(0)
)
}