hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-03 12:45:27 +02:00
Code Issues Packages Projects Releases Wiki Activity

Update zipslip_bad.py

Browse Source
This commit is contained in:
Ahmed Farid
2022-03-28 01:38:58 +00:00
committed by GitHub
parent cafbd98454
commit a50f051cdd
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
python/ql/test/experimental/query-tests/Security/CWE-022/zipslip_bad.py
View File

@@ -24,15 +24,15 @@ def unzip2(filename):
def unzip3(filename):
zf = zipfile.ZipFile(filename)
filelist = zf.namelist()
with zf.namelist() as filelist:
#BAD : This could write any file on the filesystem.
for filename in filelist:
shutil.copy(entry, "/tmp/unpack/")
for x in filelist:
shutil.copy(x, "/tmp/unpack/")
def unzip4(filename):
zf = zipfile.ZipFile(filename)
filelist = zf.namelist()
for filename in filelist:
with zf.open(filename) as srcf:
shutil.copyfileobj(srcf, dstfile)
for x in filelist:
with zf.open(x) as srcf:
shutil.copyfileobj(x, dstfile)