hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 19:26:02 +02:00
Code Issues Packages Projects Releases Wiki Activity

Use GVN in AV rule 79.

Browse Source
This commit is contained in:
Mathias Vorreiter Pedersen
2021-03-17 15:43:57 +01:00
parent fbbec5d2b9
commit a3f806bb1d
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
cpp/ql/src/jsf/4.10 Classes/AV Rule 79.ql
View File

@@ -13,6 +13,7 @@
import cpp
import Critical.NewDelete
import semmle.code.cpp.valuenumbering.GlobalValueNumbering
/**
* An expression that acquires a resource, and the kind of resource that is acquired. The
@@ -101,7 +102,7 @@ private predicate exprReleases(Expr e, Expr released, string kind) {
exprReleases(_, exprOrDereference(f.getParameter(arg).getAnAccess()), kind)
)
or
exists(Function f, ThisExpr innerThis |
exists(Function f, ThisExpr innerThis, Expr likeInnerThis |
// `e` is a call to a method that releases `this`, and `released`
// is the object that is called
(
@@ -110,7 +111,8 @@ private predicate exprReleases(Expr e, Expr released, string kind) {
) and
e.(FunctionCall).getQualifier() = exprOrDereference(released) and
innerThis.getEnclosingFunction() = f and
exprReleases(_, innerThis, kind)
globalValueNumber(innerThis) = globalValueNumber(likeInnerThis) and
exprReleases(_, likeInnerThis, kind)
)
}