hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-07-31 23:42:59 +02:00
Code Issues Packages Projects Releases Wiki Activity

Only make implicit varargs slice node for reachable calls

Browse Source
This commit is contained in:
Owen Mansel-Chan
2026-07-09 15:24:59 +01:00
parent 832f8443bb
commit a3b3381226
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
go/ql/lib/semmle/go/dataflow/internal/DataFlowNodes.qll
View File

@@ -13,7 +13,10 @@ private newtype TNode =
MkInstructionNode(IR::Instruction insn) or
MkSsaNode(SsaDefinition ssa) or
MkGlobalFunctionNode(Function f) or
MkImplicitVarargsSlice(CallExpr c) { c.hasImplicitVarargs() } or
MkImplicitVarargsSlice(IR::EvalInstruction ins) {
// We only use CallExprs with an EvalInstruction to guarantee reachability.
ins.getExpr().(CallExpr).hasImplicitVarargs()
} or
MkSliceElementNode(SliceExpr se) or
MkFlowSummaryNode(FlowSummaryImpl::Private::SummaryNode sn) or
MkDefaultPostUpdateNode(IR::Instruction insn) { insnHasPostUpdateNode(insn) }
@@ -430,7 +433,7 @@ module Public {
class ImplicitVarargsSlice extends Node, MkImplicitVarargsSlice {
CallNode call;
ImplicitVarargsSlice() { this = MkImplicitVarargsSlice(call.getCall()) }
ImplicitVarargsSlice() { this = MkImplicitVarargsSlice(call.asInstruction()) }
override ControlFlow::Root getRoot() { result = call.getRoot() }