hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-01-29 14:23:03 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix test by removing a unix-only func; add windows-only funcs

Browse Source
This commit is contained in:
Slavomir
2020-04-29 19:17:24 +03:00
parent a93477c301
commit a357121e89
3 changed files with 11 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
ql/src/semmle/go/frameworks/SystemCommandExecutors.qll
View File

@@ -30,9 +30,15 @@ private class SystemCommandExecutors extends SystemCommandExecution::Range, Data
or
pkg = "os/exec" and name = "CommandContext" and cmdArg = 1
or
// NOTE: syscall.ForkExec exists only on unix.
// NOTE: syscall.CreateProcess and syscall.CreateProcessAsUser exist only on windows.
pkg = "syscall" and
(name = "Exec" or name = "ForkExec" or name = "StartProcess") and
(name = "Exec" or name = "ForkExec" or name = "StartProcess" or name = "CreateProcess") and
cmdArg = 0
or
pkg = "syscall" and
name = "CreateProcessAsUser" and
cmdArg = 1
)
}

9
ql/test/library-tests/semmle/go/frameworks/SystemCommandExecutors/SystemCommandExecutors.expected
View File

@@ -54,8 +54,7 @@
| SystemCommandExecutors.go:96:3:96:104 | call to Command | SystemCommandExecutors.go:96:35:96:39 | shell |
| SystemCommandExecutors.go:96:3:96:104 | call to Command | SystemCommandExecutors.go:96:42:96:100 | call to toInterfaceArray |
| SystemCommandExecutors.go:100:3:100:60 | call to Exec | SystemCommandExecutors.go:100:16:100:21 | source |
| SystemCommandExecutors.go:101:3:101:73 | call to ForkExec | SystemCommandExecutors.go:101:20:101:25 | source |
| SystemCommandExecutors.go:102:3:102:77 | call to StartProcess | SystemCommandExecutors.go:102:24:102:29 | source |
| SystemCommandExecutors.go:104:3:104:76 | call to StartProcess | SystemCommandExecutors.go:104:24:104:28 | shell |
| SystemCommandExecutors.go:104:3:104:76 | call to StartProcess | SystemCommandExecutors.go:104:31:104:54 | composite literal |
| SystemCommandExecutors.go:104:3:104:76 | call to StartProcess | SystemCommandExecutors.go:104:57:104:75 | &... |
| SystemCommandExecutors.go:101:3:101:77 | call to StartProcess | SystemCommandExecutors.go:101:24:101:29 | source |
| SystemCommandExecutors.go:103:3:103:76 | call to StartProcess | SystemCommandExecutors.go:103:24:103:28 | shell |
| SystemCommandExecutors.go:103:3:103:76 | call to StartProcess | SystemCommandExecutors.go:103:31:103:54 | composite literal |
| SystemCommandExecutors.go:103:3:103:76 | call to StartProcess | SystemCommandExecutors.go:103:57:103:75 | &... |

1
ql/test/library-tests/semmle/go/frameworks/SystemCommandExecutors/SystemCommandExecutors.go
View File

@@ -98,7 +98,6 @@ func handler(w http.ResponseWriter, req *http.Request) {
// syscall
{
syscall.Exec(source, []string{"arg1", "arg2"}, []string{})
syscall.ForkExec(source, []string{"arg1", "arg2"}, &syscall.ProcAttr{})
syscall.StartProcess(source, []string{"arg1", "arg2"}, &syscall.ProcAttr{})
syscall.StartProcess(shell, []string{source, "arg2"}, &syscall.ProcAttr{})