Update tags for high precision quality queries

2025-12-17 01:03:14 +01:00 · 2025-06-13 16:53:47 +01:00
parent 76786798df
commit a2ff045a7a
22 changed files with 66 additions and 37 deletions
--- a/go/ql/src/InconsistentCode/ConstantLengthComparison.ql
+++ b/go/ql/src/InconsistentCode/ConstantLengthComparison.ql
@@ -5,7 +5,10 @@
 * @kind problem
 * @problem.severity warning
 * @id go/constant-length-comparison
- * @tags correctness
+ * @tags quality
+ *       reliability
+ *       correctness
+ *       external/cwe/cwe-129
 * @precision high
 */

--- a/go/ql/src/InconsistentCode/InconsistentLoopOrientation.ql
+++ b/go/ql/src/InconsistentCode/InconsistentLoopOrientation.ql
@@ -8,7 +8,9 @@
 * @kind problem
 * @problem.severity error
 * @id go/inconsistent-loop-direction
- * @tags correctness
+ * @tags quality
+ *       reliability
+ *       correctness
 *       external/cwe/cwe-835
 * @precision very-high
 */
--- a/go/ql/src/InconsistentCode/LengthComparisonOffByOne.ql
+++ b/go/ql/src/InconsistentCode/LengthComparisonOffByOne.ql
@@ -5,10 +5,9 @@
 * @kind problem
 * @problem.severity error
 * @id go/index-out-of-bounds
- * @tags reliability
+ * @tags quality
+ *       reliability
 *       correctness
- *       logic
- *       quality
 *       external/cwe/cwe-193
 * @precision high
 */
--- a/go/ql/src/InconsistentCode/MissingErrorCheck.ql
+++ b/go/ql/src/InconsistentCode/MissingErrorCheck.ql
@@ -5,10 +5,10 @@
 * @kind problem
 * @problem.severity warning
 * @id go/missing-error-check
- * @tags reliability
- *       correctness
- *       logic
- *       quality
+ * @tags quality
+ *       reliability
+ *       error-handling
+ *       external/cwe/cwe-252
 * @precision high
 */

--- a/go/ql/src/InconsistentCode/MistypedExponentiation.ql
+++ b/go/ql/src/InconsistentCode/MistypedExponentiation.ql
@@ -4,7 +4,10 @@
 * @kind problem
 * @problem.severity warning
 * @id go/mistyped-exponentiation
- * @tags correctness
+ * @tags quality
+ *       reliability
+ *       correctness
+ *       external/cwe/cwe-480
 * @precision high
 */

--- a/go/ql/src/InconsistentCode/UnhandledCloseWritableHandle.ql
+++ b/go/ql/src/InconsistentCode/UnhandledCloseWritableHandle.ql
@@ -7,11 +7,10 @@
 * @problem.severity warning
 * @precision high
 * @id go/unhandled-writable-file-close
- * @tags maintainability
- *  correctness
- *  call
- *  defer
- *  quality
+ * @tags quality
+ *       reliability
+ *       error-handling
+ *       external/cwe/cwe-252
 */

 import go
--- a/go/ql/src/InconsistentCode/WhitespaceContradictsPrecedence.ql
+++ b/go/ql/src/InconsistentCode/WhitespaceContradictsPrecedence.ql
@@ -1,11 +1,12 @@
 /**
 * @name Whitespace contradicts operator precedence
 * @description Nested expressions where the formatting contradicts the grouping enforced by operator precedence
- *              are difficult to read and may even indicate a bug.
+ *              are difficult to read and may indicate a bug.
 * @kind problem
 * @problem.severity warning
 * @id go/whitespace-contradicts-precedence
- * @tags maintainability
+ * @tags quality
+ *       reliability
 *       correctness
 *       external/cwe/cwe-783
 * @precision very-high
--- a/go/ql/src/InconsistentCode/WrappedErrorAlwaysNil.ql
+++ b/go/ql/src/InconsistentCode/WrappedErrorAlwaysNil.ql
@@ -4,10 +4,9 @@
 * @kind problem
 * @problem.severity warning
 * @id go/unexpected-nil-value
- * @tags reliability
- *       correctness
- *       logic
- *       quality
+ * @tags quality
+ *       reliability
+ *       error-handling
 * @precision high
 */

--- a/go/ql/src/RedundantCode/CompareIdenticalValues.ql
+++ b/go/ql/src/RedundantCode/CompareIdenticalValues.ql
@@ -5,7 +5,9 @@
 * @kind problem
 * @problem.severity warning
 * @id go/comparison-of-identical-expressions
- * @tags correctness
+ * @tags quality
+ *       reliability
+ *       correctness
 *       external/cwe/cwe-570
 *       external/cwe/cwe-571
 * @precision very-high
--- a/go/ql/src/RedundantCode/DeadStoreOfField.ql
+++ b/go/ql/src/RedundantCode/DeadStoreOfField.ql
@@ -4,7 +4,9 @@
 * @kind problem
 * @problem.severity warning
 * @id go/useless-assignment-to-field
- * @tags maintainability
+ * @tags quality
+ *       maintainability
+ *       useless-code
 *       external/cwe/cwe-563
 * @precision very-high
 */
--- a/go/ql/src/RedundantCode/DeadStoreOfLocal.ql
+++ b/go/ql/src/RedundantCode/DeadStoreOfLocal.ql
@@ -5,7 +5,9 @@
 * @kind problem
 * @problem.severity warning
 * @id go/useless-assignment-to-local
- * @tags maintainability
+ * @tags quality
+ *       maintainability
+ *       useless-code
 *       external/cwe/cwe-563
 * @precision very-high
 */
--- a/go/ql/src/RedundantCode/DuplicateBranches.ql
+++ b/go/ql/src/RedundantCode/DuplicateBranches.ql
@@ -6,7 +6,8 @@
 * @problem.severity warning
 * @precision very-high
 * @id go/duplicate-branches
- * @tags maintainability
+ * @tags quality
+ *       reliability
 *       correctness
 *       external/cwe/cwe-561
 */
--- a/go/ql/src/RedundantCode/DuplicateCondition.ql
+++ b/go/ql/src/RedundantCode/DuplicateCondition.ql
@@ -5,7 +5,8 @@
 * @kind problem
 * @problem.severity error
 * @id go/duplicate-condition
- * @tags maintainability
+ * @tags quality
+ *       reliability
 *       correctness
 *       external/cwe/cwe-561
 * @precision very-high
--- a/go/ql/src/RedundantCode/DuplicateSwitchCase.ql
+++ b/go/ql/src/RedundantCode/DuplicateSwitchCase.ql
@@ -5,7 +5,8 @@
 * @kind problem
 * @problem.severity error
 * @id go/duplicate-switch-case
- * @tags maintainability
+ * @tags quality
+ *       reliability
 *       correctness
 *       external/cwe/cwe-561
 * @precision very-high
--- a/go/ql/src/RedundantCode/ExprHasNoEffect.ql
+++ b/go/ql/src/RedundantCode/ExprHasNoEffect.ql
@@ -5,7 +5,8 @@
 * @kind problem
 * @problem.severity warning
 * @id go/useless-expression
- * @tags maintainability
+ * @tags quality
+ *       reliability
 *       correctness
 *       external/cwe/cwe-480
 *       external/cwe/cwe-561
--- a/go/ql/src/RedundantCode/ImpossibleInterfaceNilCheck.ql
+++ b/go/ql/src/RedundantCode/ImpossibleInterfaceNilCheck.ql
@@ -4,7 +4,10 @@
 * @kind problem
 * @problem.severity warning
 * @id go/impossible-interface-nil-check
- * @tags correctness
+ * @tags quality
+ *       reliability
+ *       correctness
+ *       external/cwe/cwe-570
 * @precision high
 */

--- a/go/ql/src/RedundantCode/NegativeLengthCheck.ql
+++ b/go/ql/src/RedundantCode/NegativeLengthCheck.ql
@@ -8,8 +8,10 @@
 * @problem.severity warning
 * @precision very-high
 * @id go/negative-length-check
- * @tags correctness
- *       quality
+ * @tags quality
+ *       reliability
+ *       correctness
+ *       external/cwe/cwe-571
 */

 import go
--- a/go/ql/src/RedundantCode/RedundantExpr.ql
+++ b/go/ql/src/RedundantCode/RedundantExpr.ql
@@ -6,7 +6,9 @@
 * @kind problem
 * @problem.severity warning
 * @id go/redundant-operation
- * @tags correctness
+ * @tags quality
+ *       reliability
+ *       correctness
 *       external/cwe/cwe-480
 *       external/cwe/cwe-561
 * @precision very-high
--- a/go/ql/src/RedundantCode/RedundantRecover.ql
+++ b/go/ql/src/RedundantCode/RedundantRecover.ql
@@ -6,9 +6,10 @@
 * @kind problem
 * @problem.severity warning
 * @id go/redundant-recover
- * @tags maintainability
+ * @tags quality
+ *       reliability
 *       correctness
- *       quality
+ *       external/cwe/cwe-248
 * @precision high
 */

--- a/go/ql/src/RedundantCode/SelfAssignment.ql
+++ b/go/ql/src/RedundantCode/SelfAssignment.ql
@@ -4,7 +4,9 @@
 * @kind problem
 * @problem.severity warning
 * @id go/redundant-assignment
- * @tags correctness
+ * @tags quality
+ *       reliability
+ *       correctness
 *       external/cwe/cwe-480
 *       external/cwe/cwe-561
 * @precision high
--- a/go/ql/src/RedundantCode/ShiftOutOfRange.ql
+++ b/go/ql/src/RedundantCode/ShiftOutOfRange.ql
@@ -6,7 +6,9 @@
 * @problem.severity warning
 * @id go/shift-out-of-range
 * @precision very-high
- * @tags correctness
+ * @tags quality
+ *       reliability
+ *       correctness
 *       external/cwe/cwe-197
 */

--- a/go/ql/src/RedundantCode/UnreachableStatement.ql
+++ b/go/ql/src/RedundantCode/UnreachableStatement.ql
@@ -5,7 +5,8 @@
 * @kind problem
 * @problem.severity warning
 * @id go/unreachable-statement
- * @tags maintainability
+ * @tags quality
+ *       reliability
 *       correctness
 *       external/cwe/cwe-561
 * @precision very-high