hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-16 16:53:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

Guards: Improve performance for uniqueValue.

Browse Source
This commit is contained in:
Anders Schack-Mulligen
2025-10-01 14:08:37 +02:00
parent a0b533bd40
commit a1028d604c
1 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
shared/controlflow/codeql/controlflow/Guards.qll
View File

@@ -692,6 +692,9 @@ module Make<
* Holds if `e` equals `k` and may be assigned to `v`. The boolean
* `fromBackEdge` indicates whether the flow from `e` to `v` goes through a
* back edge.
*
* This predicate is restricted to cases where all such possible values are
* constants, which means that the `GuardValue`s are singleton values.
*/
private predicate possibleValue(SsaDefinition v, boolean fromBackEdge, Expr e, GuardValue k) {
not hasPossibleUnknownValue(v) and
@@ -711,9 +714,10 @@ module Make<
private predicate uniqueValue(SsaDefinition v, Expr e, GuardValue k) {
possibleValue(v, false, e, k) and
not possibleValue(v, true, e, k) and
forex(Expr other, GuardValue otherval | possibleValue(v, _, other, otherval) and other != e |
disjointValues(otherval, k)
)
// there's only one expression with the value `k`
1 = strictcount(Expr e0 | possibleValue(v, _, e0, k)) and
// and `v` has at least two possible values
2 <= strictcount(GuardValue k0 | possibleValue(v, _, _, k0))
}
/**