hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-17 01:03:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #962 from jbj/IRGuards-cached

Browse Source 
C++: Reduce the IRGuards to two cached stages
This commit is contained in:
Robert Marsh
2019-02-21 10:50:19 -08:00
committed by GitHub
parent 0ca67880b2 d200bda2ad
commit a0c12c46e5
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
cpp/ql/src/semmle/code/cpp/controlflow/IRGuards.qll
View File

@@ -16,8 +16,8 @@ private predicate isUnreachedBlock(IRBlock block) {
* A Boolean condition in the AST that guards one or more basic blocks. This includes
* operands of logical operators but not switch statements.
*/
class GuardCondition extends Expr {
GuardCondition() {
cached class GuardCondition extends Expr {
cached GuardCondition() {
exists(IRGuardCondition ir | this = ir.getUnconvertedResultExpression())
or
// no binary operators in the IR
@@ -238,10 +238,10 @@ private class GuardConditionFromIR extends GuardCondition {
* don't have an explicit representation in the IR, and therefore will not appear as
* IRGuardConditions.
*/
class IRGuardCondition extends Instruction {
cached class IRGuardCondition extends Instruction {
ConditionalBranchInstruction branch;
IRGuardCondition() {
cached IRGuardCondition() {
branch = get_branch_for_condition(this)
}
@@ -281,7 +281,7 @@ class IRGuardCondition extends Instruction {
ne.controls(controlled, testIsTrue.booleanNot()))
}
predicate controlsEdge(IRBlock pred, IRBlock succ, boolean testIsTrue) {
cached predicate controlsEdge(IRBlock pred, IRBlock succ, boolean testIsTrue) {
pred.getASuccessor() = succ and
controls(pred, testIsTrue)
or