hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-01 03:35:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

Python: Expand commentary

Browse Source
This commit is contained in:
Rasmus Lerchedahl Petersen
2021-04-07 08:32:40 +02:00
parent f22db2a30b
commit a006a92f8d
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
python/ql/src/Security/CWE-327/Ssl.qll
View File

@@ -141,13 +141,15 @@ class UnspecificSSLContextCreation extends SSLContextCreation, UnspecificContext
UnspecificSSLContextCreation() { library = "ssl" }
override ProtocolVersion getUnrestriction() {
// Case: A protocol argument is present.
result = UnspecificContextCreation.super.getUnrestriction() and
// These are turned off by default
// see https://docs.python.org/3/library/ssl.html#ssl-contexts
not result in ["SSLv2", "SSLv3"]
or
// The default argument is TLS and the SSL versions are turned off by default.
// Case: No protocol arguemnt is present.
not exists(this.getProtocol()) and
// The default argument is TLS and the SSL versions are turned off by default.
result in ["TLSv1", "TLSv1_1", "TLSv1_2", "TLSv1_3"]
}
}