hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-17 01:03:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

Java: rename 'isSingleReplaceAll' and 'isDoubleReplaceOrReplaceAll'

Browse Source
This commit is contained in:
Jami Cogswell
2025-03-17 15:07:10 -04:00
parent 41aeb874f1
commit 9d6a10b601
1 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
java/ql/lib/semmle/code/java/security/PathSanitizer.qll
View File

@@ -414,7 +414,9 @@ private predicate isReplaceTarget(StringReplaceCall replaceCall, CompileTimeCons
}
/** Holds if a single `replaceAllCall` replaces all directory characters. */
private predicate isSingleReplaceAll(StringReplaceAllCall replaceAllCall) {
private predicate replacesDirectoryCharactersWithSingleReplaceAll(
StringReplaceAllCall replaceAllCall
) {
exists(CompileTimeConstantExpr target, string targetValue |
isReplaceAllTarget(replaceAllCall, target) and
target.getStringValue() = targetValue
@@ -436,7 +438,9 @@ private predicate isSingleReplaceAll(StringReplaceAllCall replaceAllCall) {
* Holds if there are two chained replacement calls, `rc1` and `rc2`, that replace
* '.' and one of '/' or '\'.
*/
private predicate isDoubleReplaceOrReplaceAll(StringReplaceOrReplaceAllCall rc1) {
private predicate replacesDirectoryCharactersWithDoubleReplaceOrReplaceAll(
StringReplaceOrReplaceAllCall rc1
) {
exists(
CompileTimeConstantExpr target1, string targetValue1, StringReplaceOrReplaceAllCall rc2,
CompileTimeConstantExpr target2, string targetValue2
@@ -471,8 +475,8 @@ private predicate isDoubleReplaceOrReplaceAll(StringReplaceOrReplaceAllCall rc1)
*/
private class ReplaceDirectoryCharactersSanitizer extends StringReplaceOrReplaceAllCall {
ReplaceDirectoryCharactersSanitizer() {
isSingleReplaceAll(this) or
isDoubleReplaceOrReplaceAll(this)
replacesDirectoryCharactersWithSingleReplaceAll(this) or
replacesDirectoryCharactersWithDoubleReplaceOrReplaceAll(this)
}
}