hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-20 22:44:52 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #19104 from michaelnebel/ql4ql/excludeprintastinlineexpect

Browse Source 
QL4QL: Exclude PrintAst like tests from being reported as having missing InlineExpectations.
This commit is contained in:
Erik Krogh Kristensen
2025-03-25 09:42:22 +01:00
committed by GitHub
parent f7026c29cc be4c9d8815
commit 9d3d3deffa
8 changed files with 20 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
ql/ql/src/codeql_ql/ast/Yaml.qll
View File

@@ -64,4 +64,15 @@ class QlRefDocument extends YamlDocument {
value = n.lookup("postprocess").(YamlSequence).getElement(_)
)
}
predicate isPrintAst() {
this.getFile().getStem() = "PrintAst"
or
exists(YamlMapping n, YamlScalar value |
n.getDocument() = this and
value.getValue().matches("%PrintAst%")
|
value = n.lookup("query")
)
}
}

4
ql/ql/src/queries/style/QlRefInlineExpectations.ql
View File

@@ -11,5 +11,7 @@ import ql
import codeql_ql.ast.Yaml
from QlRefDocument f
where not f.usesInlineExpectations()
where
not f.usesInlineExpectations() and
not f.isPrintAst()
select f, "Query test does not use inline test expectations."

1
ql/ql/test/queries/style/QlRefInlineExpectations/PrintAst.expected Normal file
View File

@@ -0,0 +1 @@
| |

1
ql/ql/test/queries/style/QlRefInlineExpectations/PrintAst.qlref Normal file
View File

@@ -0,0 +1 @@
dummy/PrintAst.ql

1
ql/ql/test/queries/style/QlRefInlineExpectations/Test4.expected Normal file
View File

@@ -0,0 +1 @@
| |

1
ql/ql/test/queries/style/QlRefInlineExpectations/Test4.qlref Normal file
View File

@@ -0,0 +1 @@
query: dummy/PrintAst.ql

1
ql/ql/test/queries/style/QlRefInlineExpectations/dummy/PrintAst.expected Normal file
View File

@@ -0,0 +1 @@
| |

1
ql/ql/test/queries/style/QlRefInlineExpectations/dummy/PrintAst.ql Normal file
View File

@@ -0,0 +1 @@
select ""