hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-29 10:45:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

C#: Exclude overrides of Equals and GetHashCode in model generation.

Browse Source
This commit is contained in:
Michael Nebel
2022-03-31 13:08:50 +02:00
parent f480ab9fd2
commit 99bbca8c31
1 changed files with 13 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
csharp/ql/src/utils/model-generator/internal/CaptureModelsSpecific.qll
View File

@@ -6,6 +6,7 @@ private import csharp as CS
private import semmle.code.csharp.commons.Util as Util
private import semmle.code.csharp.commons.Collections as Collections
private import semmle.code.csharp.dataflow.internal.DataFlowDispatch
private import semmle.code.csharp.frameworks.System as System
import semmle.code.csharp.dataflow.ExternalFlow as ExternalFlow
import semmle.code.csharp.dataflow.internal.DataFlowImplCommon as DataFlowImplCommon
import semmle.code.csharp.dataflow.internal.DataFlowPrivate as DataFlowPrivate
@@ -16,14 +17,25 @@ module TaintTracking = CS::TaintTracking;
class Type = CS::Type;
/**
* Holds if `api` is an override of `GetHashCode` or `Equals`.
*/
private predicate isIrrellevantObjectOveride(CS::Callable api) {
exists(System::SystemObjectClass c |
api = c.getGetHashCodeMethod().getAnOverrider*() or
api = c.getEqualsMethod().getAnOverrider*()
)
}
/**
* Holds if it is relevant to generate models for `api`.
*/
private predicate isRelevantForModels(CS::Callable api) {
[api.(CS::Modifiable), api.(CS::Accessor).getDeclaration()].isEffectivelyPublic() and
api.getDeclaringType().getNamespace().getQualifiedName() != "" and
not api instanceof CS::ConversionOperator and
not api instanceof Util::MainMethod and
api.getDeclaringType().getNamespace().getQualifiedName() != ""
not isIrrellevantObjectOveride(api)
}
/**