hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-28 02:05:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix first set of code review comments

Browse Source
This commit is contained in:
Tamas Vajk
2020-08-25 17:11:34 +02:00
parent 9cdee63ed7
commit 997388b075
3 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
csharp/extractor/Semmle.Extraction.CIL/Entities/File.cs
View File

@@ -37,7 +37,7 @@ namespace Semmle.Extraction.CIL.Entities
get
{
var directoryName = System.IO.Path.GetDirectoryName(path);
if (directoryName == null)
if (directoryName is null)
throw new InternalError($"Directory name for path '{path}' is null.");
var parent = cx.CreateFolder(directoryName);

4
csharp/extractor/Semmle.Extraction.CIL/Entities/Method.cs
View File

@@ -146,7 +146,7 @@ namespace Semmle.Extraction.CIL.Entities
readonly PDB.IMethod? methodDebugInformation;
readonly Type declaringType;
string name;
readonly string name;
LocalVariable[]? locals;
public MethodImplementation? Implementation { get; private set; }
@@ -417,7 +417,7 @@ namespace Semmle.Extraction.CIL.Entities
var parentMethod = parent as Method;
var declType = parentMethod == null ? parent as Type : parentMethod.DeclaringType;
var declType = parentMethod is null ? parent as Type : parentMethod.DeclaringType;
if (declType is null)
throw new InternalError("Parent context of method is not a type");

6
csharp/extractor/Semmle.Extraction.CIL/Entities/Namespace.cs
View File

@@ -20,7 +20,7 @@ namespace Semmle.Extraction.CIL.Entities
public Namespace? ParentNamespace;
public readonly string Name;
public bool IsGlobalNamespace => ParentNamespace == null;
public bool IsGlobalNamespace => ParentNamespace is null;
public override string IdSuffix => ";namespace";
@@ -85,8 +85,8 @@ namespace Semmle.Extraction.CIL.Entities
get
{
yield return Tuples.namespaces(this, Name);
if (!IsGlobalNamespace)
yield return Tuples.parent_namespace(this, ParentNamespace!);
if (ParentNamespace is object)
yield return Tuples.parent_namespace(this, ParentNamespace);
}
}
}