hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-28 02:05:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

C#: Remove the Csv name where appropriate.

Browse Source
This commit is contained in:
Michael Nebel
2022-10-28 13:04:48 +02:00
parent d11bca0cdc
commit 990a898cc7
8 changed files with 17 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
csharp/ql/lib/semmle/code/csharp/dataflow/ExternalFlow.qll
View File

@@ -1,7 +1,8 @@
/**
* INTERNAL use only. This is an experimental API subject to change without notice.
*
* Provides classes and predicates for dealing with flow models specified in CSV format.
* Provides classes and predicates for dealing with MaD flow models specified
* in data extensions and CSV format.
*
* The CSV specification has the following columns:
* - Sources:
@@ -380,7 +381,7 @@ private predicate canonicalNamespaceLink(string namespace, string subns) {
}
/**
* Holds if CSV framework coverage of `namespace` is `n` api endpoints of the
* Holds if MaD framework coverage of `namespace` is `n` api endpoints of the
* kind `(kind, part)`.
*/
predicate modelCoverage(string namespace, int namespaces, string kind, string part, int n) {
@@ -412,8 +413,8 @@ predicate modelCoverage(string namespace, int namespaces, string kind, string pa
)
}
/** Provides a query predicate to check the CSV data for validation errors. */
module CsvValidation {
/** Provides a query predicate to check the MaD models for validation errors. */
module ModelValidation {
private string getInvalidModelInput() {
exists(string pred, AccessPath input, string part |
sinkModel(_, _, _, _, _, _, input, _, _) and pred = "sink"
@@ -536,7 +537,7 @@ module CsvValidation {
)
}
/** Holds if some row in a CSV-based flow model appears to contain typos. */
/** Holds if some row in a MaD flow model appears to contain typos. */
query predicate invalidModelRow(string msg) {
msg =
[
@@ -709,7 +710,7 @@ predicate hasSummary(Callable c, boolean generated) { summaryElement(c, _, _, _,
cached
private module Cached {
/**
* Holds if `node` is specified as a source with the given kind in a CSV flow
* Holds if `node` is specified as a source with the given kind in a MaD flow
* model.
*/
cached
@@ -718,7 +719,7 @@ private module Cached {
}
/**
* Holds if `node` is specified as a sink with the given kind in a CSV flow
* Holds if `node` is specified as a sink with the given kind in a MaD flow
* model.
*/
cached

2
csharp/ql/lib/semmle/code/csharp/dataflow/internal/AccessPathSyntax.qll
View File

@@ -1,5 +1,5 @@
/**
* Module for parsing access paths from CSV models, both the identifying access path used
* Module for parsing access paths from MaD models, both the identifying access path used
* by dynamic languages, and the input/output specifications for summary steps.
*
* This file is used by the shared data flow library and by the JavaScript libraries

2
csharp/ql/lib/semmle/code/csharp/dataflow/internal/DataFlowPrivate.qll
View File

@@ -2246,7 +2246,7 @@ string parameterQualifiedTypeNamesToString(DotNet::Callable c) {
}
/**
* A module containing predicates related to generating models as data.
* A module containing predicates related to generating MaD models.
*/
module Csv {
/** Holds if the summary should apply for all overrides of `c`. */

6
csharp/ql/lib/semmle/code/csharp/dataflow/internal/FlowSummaryImpl.qll
View File

@@ -892,7 +892,7 @@ module Private {
}
/**
* Provides a means of translating externally (e.g., CSV) defined flow
* Provides a means of translating externally (e.g., MaD) defined flow
* summaries into a `SummarizedCallable`s.
*/
module External {
@@ -1121,7 +1121,7 @@ module Private {
}
/**
* Holds if `node` is specified as a source with the given kind in a CSV flow
* Holds if `node` is specified as a source with the given kind in a MaD flow
* model.
*/
predicate isSourceNode(InterpretNode node, string kind) {
@@ -1132,7 +1132,7 @@ module Private {
}
/**
* Holds if `node` is specified as a sink with the given kind in a CSV flow
* Holds if `node` is specified as a sink with the given kind in a MaD flow
* model.
*/
predicate isSinkNode(InterpretNode node, string kind) {

2
csharp/ql/test/library-tests/dataflow/external-models/ExternalFlow.ql
View File

@@ -5,7 +5,7 @@
import csharp
import DataFlow::PathGraph
import semmle.code.csharp.dataflow.ExternalFlow
import CsvValidation
import ModelValidation
class Conf extends TaintTracking::Configuration {
Conf() { this = "ExternalFlow" }

2
csharp/ql/test/library-tests/dataflow/external-models/sinks.ql
View File

@@ -1,7 +1,7 @@
import csharp
import DataFlow
import semmle.code.csharp.dataflow.ExternalFlow
import CsvValidation
import ModelValidation
from DataFlow::Node node, string kind
where sinkNode(node, kind)

2
csharp/ql/test/library-tests/dataflow/external-models/srcs.ql
View File

@@ -1,7 +1,7 @@
import csharp
import DataFlow
import semmle.code.csharp.dataflow.ExternalFlow
import CsvValidation
import ModelValidation
from DataFlow::Node node, string kind
where sourceNode(node, kind)

2
csharp/ql/test/library-tests/dataflow/external-models/steps.ql
View File

@@ -1,7 +1,7 @@
import csharp
import DataFlow
import semmle.code.csharp.dataflow.ExternalFlow
import CsvValidation
import ModelValidation
import semmle.code.csharp.dataflow.FlowSummary
import semmle.code.csharp.dataflow.internal.DataFlowDispatch as DataFlowDispatch
import semmle.code.csharp.dataflow.internal.FlowSummaryImpl as FlowSummaryImpl