hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 11:15:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

Change logic for autobuild failures

Browse Source 
This is to account for multiple attempted rules that failed
This commit is contained in:
Michael B. Gale
2023-02-15 11:37:36 +00:00
parent 99924919be
commit 9865c506e6
1 changed files with 11 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
csharp/autobuilder/Semmle.Autobuild.CSharp/CSharpAutobuilder.cs
View File

@@ -122,13 +122,13 @@ namespace Semmle.Autobuild.CSharp
protected override void AutobuildFailureDiagnostic()
{
DiagnosticMessage message;
// if `ScriptPath` is not null here, the `BuildCommandAuto` rule was
// run and found at least one script to execute
if (this.buildCommandAutoRule is not null &&
this.buildCommandAutoRule.ScriptPath is not null)
{
DiagnosticMessage message;
// if we found multiple build scripts in the project directory, then we can say
// as much to indicate that we may have picked the wrong one;
// otherwise, we just report that the one script we found didn't work
@@ -155,27 +155,23 @@ namespace Semmle.Autobuild.CSharp
"You can manually specify a suitable build command for your project."
};
}
message.Severity = DiagnosticMessage.TspSeverity.Error;
Diagnostic(message);
}
// both dotnet and msbuild builds require project or solution files; if we haven't found any
// then neither of those rules would've worked
else if (this.ProjectsOrSolutionsToBuild.Count == 0)
if (this.ProjectsOrSolutionsToBuild.Count == 0)
{
var source = GetDiagnosticSource("no-projects-or-solutions", "No project or solutions files found");
message = new DiagnosticMessage(source)
var message = new DiagnosticMessage(source)
{
PlaintextMessage = "CodeQL could not find any project or solution files in your repository."
PlaintextMessage = "CodeQL could not find any project or solution files in your repository.",
Severity = DiagnosticMessage.TspSeverity.Error
};
}
else
{
// none of the above apply; produce a generic autobuild failure message
base.AutobuildFailureDiagnostic();
return;
}
// all messages generated here are errors
message.Severity = DiagnosticMessage.TspSeverity.Error;
Diagnostic(message);
Diagnostic(message);
}
}
/// <summary>