hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 11:15:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

don't depend on the callgraph in KernelArraySummary

Browse Source
This commit is contained in:
erik-krogh
2023-03-14 09:20:24 +01:00
parent 4307889b1f
commit 984a589954
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
ruby/ql/lib/codeql/ruby/frameworks/core/Kernel.qll
View File

@@ -198,6 +198,8 @@ module Kernel {
}
}
private import codeql.ruby.ast.internal.Module as Module
/**
* A call to `Array()`, that converts it's singular argument to an array.
* This summary is based on https://ruby-doc.org/3.2.1/Kernel.html#method-i-Array
@@ -205,11 +207,12 @@ module Kernel {
private class KernelArraySummary extends SummarizedCallable {
KernelArraySummary() { this = "Array()" }
override MethodCall getACall() {
override MethodCall getACallSimple() {
result.getMethodName() = "Array" and
// I have to have a simplified "KernelMethodCall" implementation inlined here, because relying on `UnknownMethodCall` results in non-monotonic recursion (even if using `getACall`).
(
result = API::getTopLevelMember("Kernel").getAMethodCall(_).asExpr().getExpr()
// similar to `getAStaticArrayCall` from Array.qll
Module::resolveConstantReadAccess(result.getReceiver()) = Module::TResolved("Kernel")
or
result.getReceiver() instanceof SelfVariableAccess
)