hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-16 16:53:25 +01:00
Code Issues Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse Source 
Co-authored-by: Taus <tausbn@github.com>
This commit is contained in:
Asger F
2025-07-03 08:44:33 +02:00
committed by GitHub
parent d85838477e
commit 98319ce2ad
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
javascript/ql/lib/semmle/javascript/internal/BindingInfo.qll
View File

@@ -26,7 +26,7 @@ class TypeNameBindingNode extends NameResolution::Node {
}
/**
* Holds if this refers a value exported by the given module, with the given
* Holds if this refers to a value exported by the given module, with the given
* qualified name. If the `qualifiedName` is empty, this refers to the module itself.
*
* For example, the type annotations below have the following name bindings:
@@ -151,8 +151,8 @@ class ExprNameBindingNode extends NameResolution::Node {
* ```ts
* import * as f from "foo";
*
* var x = f; // hasQualifiedName(f, "")
* var x = f.x.y; // hasQualifiedName(f, "x.y")
* var x = f; // hasQualifiedName("f", "")
* var x = f.x.y; // hasQualifiedName("f", "x.y")
* ```
*/
predicate hasQualifiedName(string moduleName, string qualifiedName) {

2
javascript/ql/src/change-notes/2025-06-24-no-type-extraction-breaking.md
View File

@@ -2,7 +2,7 @@
category: breaking
---
* The `Type` and `Symbol` classes have been deprecated and will be empty in newly extracted databases, since the TypeScript extractor no longer populates them.
This is breaking change for custom queries that explicitly relied on these classes.
This is a breaking change for custom queries that explicitly relied on these classes.
Such queries will still compile, but with deprecation warnings, and may have different query results due to type information no longer being available.
We expect most custom queries will not be affected, however. If a custom query has no deprecation warnings, it should not be affected by this change.
Uses of `getType()` should be rewritten to use the new `getTypeBinding()` or `getNameBinding()` APIs instead.