hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 11:15:13 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #641 from geoffw0/exprnoeffect2

Browse Source 
CPP: More tests of isSideEffectFree() / ExprHasNoEffect.ql
This commit is contained in:
Robert Marsh
2018-12-11 12:17:30 -08:00
committed by GitHub
parent a4b3b1e8c8 e7390f3ea5
commit 98005edd9d
4 changed files with 39 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
cpp/ql/test/library-tests/sideEffects/functions/error.cpp Normal file
View File

@@ -0,0 +1,19 @@
// semmle-extractor-options: --expect_errors
void functionBeforeError()
{
}
void functionWithError1()
{
aaaaaaaaaa(); // error
}
void functionWithError2()
{
int i = aaaaaaaaaa(); // error
}
void functionAfterError()
{
}

4
cpp/ql/test/library-tests/sideEffects/functions/sideEffects.expected
View File

@@ -43,6 +43,10 @@
| cpp.cpp:87:5:87:26 | functionAccessesStatic | int | false |
| cpp.cpp:93:6:93:14 | increment | int & -> void | false |
| cpp.cpp:97:6:97:16 | doIncrement | void | false |
| error.cpp:3:6:3:24 | functionBeforeError | void | true |
| error.cpp:7:6:7:23 | functionWithError1 | void | false |
| error.cpp:12:6:12:23 | functionWithError2 | void | false |
| error.cpp:17:6:17:23 | functionAfterError | void | true |
| file://:0:0:0:0 | operator= | __va_list_tag & | false |
| file://:0:0:0:0 | operator= | __va_list_tag & | false |
| sideEffects.c:4:5:4:6 | f1 | int | true |

3
cpp/ql/test/query-tests/Likely Bugs/Likely Typos/ExprHasNoEffect/ExprHasNoEffect.expected
View File

@@ -1,5 +1,8 @@
| calls.cpp:8:5:8:5 | 1 | This expression has no effect. | calls.cpp:8:5:8:5 | 1 | |
| calls.cpp:12:5:12:16 | call to thingy | This expression has no effect (because $@ has no external side effects). | calls.cpp:7:15:7:20 | thingy | thingy |
| expr.cpp:8:2:8:2 | 0 | This expression has no effect. | expr.cpp:8:2:8:2 | 0 | |
| expr.cpp:9:7:9:7 | 0 | This expression has no effect. | expr.cpp:9:7:9:7 | 0 | |
| expr.cpp:10:2:10:5 | ... , ... | This expression has no effect. | expr.cpp:10:2:10:5 | ... , ... | |
| preproc.c:89:2:89:4 | call to fn4 | This expression has no effect (because $@ has no external side effects). | preproc.c:33:5:33:7 | fn4 | fn4 |
| preproc.c:94:2:94:4 | call to fn9 | This expression has no effect (because $@ has no external side effects). | preproc.c:78:5:78:7 | fn9 | fn9 |
| template.cpp:19:3:19:3 | call to operator++ | This expression has no effect (because $@ has no external side effects). | template.cpp:9:10:9:19 | operator++ | operator++ |

13
cpp/ql/test/query-tests/Likely Bugs/Likely Typos/ExprHasNoEffect/expr.cpp Normal file
View File

@@ -0,0 +1,13 @@
namespace Expr {
int i;
void comma_expr_test()
{
i++, i++; // GOOD
0, i++; // BAD (first part)
i++, 0; // BAD (second part)
0, 0; // BAD (whole)
}
}