hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-24 08:15:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

Test: support queries that don't select a Location

Browse Source
This commit is contained in:
Asger F
2025-02-11 12:52:05 +01:00
parent 5b0eb0f6cc
commit 967c0860f9
1 changed files with 109 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

121
shared/util/codeql/util/test/InlineExpectationsTest.qll
View File

@@ -643,12 +643,109 @@ module TestPostProcessing {
module Make<InlineExpectationsTestSig Input, InputSig<Input> Input2> {
private import InlineExpectationsTest as InlineExpectationsTest
private import InlineExpectationsTest::Make<Input>
bindingset[loc]
private predicate parseLocationString(
string loc, string relativePath, int sl, int sc, int el, int ec
) {
relativePath = loc.splitAt(":", 0) and
sl = loc.splitAt(":", 1).toInt() and
sc = loc.splitAt(":", 2).toInt() and
el = loc.splitAt(":", 3).toInt() and
ec = loc.splitAt(":", 4).toInt()
}
pragma[nomagic]
private string getRelativePathTo(string absolutePath) {
exists(Input::Location loc |
loc.hasLocationInfo(absolutePath, _, _, _, _) and
result = Input2::getRelativeUrl(loc).splitAt(":", 0)
)
}
private newtype TTestLocation =
MkInputLocation(Input::Location loc) or
MkResultLocation(string relativePath, int sl, int sc, int el, int ec) {
exists(string data |
queryResults(_, _, _, data) and
parseLocationString(data, relativePath, sl, sc, el, ec) and
not Input2::getRelativeUrl(_) = data // avoid duplicate locations
)
}
/**
* A location that is either an `Input::Location` or a location from an alert.
*
* We use this location type to support queries that select a location that does not correspond
* to an instance of `Input::Location`.
*/
abstract private class TestLocationImpl extends TTestLocation {
string getAbsoluteFile() { this.hasLocationInfo(result, _, _, _, _) }
int getStartLine() { this.hasLocationInfo(_, result, _, _, _) }
int getStartColumn() { this.hasLocationInfo(_, _, result, _, _) }
int getEndLine() { this.hasLocationInfo(_, _, _, result, _) }
int getEndColumn() { this.hasLocationInfo(_, _, _, _, result) }
abstract string getRelativeUrl();
abstract string toString();
abstract predicate hasLocationInfo(string file, int sl, int sc, int el, int ec);
}
private class LocationFromResult extends TestLocationImpl, MkResultLocation {
override string getRelativeUrl() {
exists(string file, int sl, int sc, int el, int ec |
this = MkResultLocation(file, sl, sc, el, ec) and
result = file + ":" + sl + ":" + sc + ":" + el + ":" + ec
)
}
override string toString() { result = this.getRelativeUrl() }
override predicate hasLocationInfo(string file, int sl, int sc, int el, int ec) {
this = MkResultLocation(getRelativePathTo(file), sl, sc, el, ec)
}
}
private class LocationFromInput extends TestLocationImpl, MkInputLocation {
private Input::Location loc;
LocationFromInput() { this = MkInputLocation(loc) }
override string getRelativeUrl() { result = Input2::getRelativeUrl(loc) }
override string toString() { result = this.getRelativeUrl() }
override predicate hasLocationInfo(string file, int sl, int sc, int el, int ec) {
loc.hasLocationInfo(file, sl, sc, el, ec)
}
}
final class TestLocation = TestLocationImpl;
module TestImpl2 implements InlineExpectationsTestSig {
final class Location = TestLocation;
class ExpectationComment instanceof Input::ExpectationComment {
string getContents() { result = super.getContents() }
Location getLocation() { result = MkInputLocation(super.getLocation()) }
string toString() { result = super.toString() }
}
}
private import InlineExpectationsTest::Make<TestImpl2>
/** Holds if the given locations refer to the same lines, but possibly with different column numbers. */
bindingset[loc1, loc2]
pragma[inline_late]
private predicate sameLineInfo(Input::Location loc1, Input::Location loc2) {
private predicate sameLineInfo(TestLocation loc1, TestLocation loc2) {
exists(string file, int line1, int line2 |
loc1.hasLocationInfo(file, line1, _, line2, _) and
loc2.hasLocationInfo(file, line1, _, line2, _)
@@ -656,8 +753,8 @@ module TestPostProcessing {
}
pragma[nomagic]
private predicate mainQueryResult(int row, int column, Input::Location loc) {
queryResults(mainResultSet(), row, column, Input2::getRelativeUrl(loc))
private predicate mainQueryResult(int row, int column, TestLocation loc) {
queryResults(mainResultSet(), row, column, loc.getRelativeUrl())
}
/**
@@ -668,7 +765,7 @@ module TestPostProcessing {
*/
private string getSourceTag(int row) {
getQueryKind() = "path-problem" and
exists(Input::Location sourceLoc, Input::Location selectLoc |
exists(TestLocation sourceLoc, TestLocation selectLoc |
mainQueryResult(row, 0, selectLoc) and
mainQueryResult(row, 2, sourceLoc) and
if sameLineInfo(selectLoc, sourceLoc) then result = "Alert" else result = "Source"
@@ -733,7 +830,7 @@ module TestPostProcessing {
}
additional predicate hasPathProblemSource(
int row, Input::Location location, string element, string tag, string value
int row, TestLocation location, string element, string tag, string value
) {
getQueryKind() = "path-problem" and
mainQueryResult(row, 2, location) and
@@ -742,7 +839,7 @@ module TestPostProcessing {
value = ""
}
predicate hasActualResult(Input::Location location, string element, string tag, string value) {
predicate hasActualResult(TestLocation location, string element, string tag, string value) {
hasPathProblemSource(_, location, element, tag, value)
}
}
@@ -770,7 +867,7 @@ module TestPostProcessing {
private predicate hasPathProblemSource = PathProblemSourceTestInput::hasPathProblemSource/5;
private predicate hasPathProblemSink(
int row, Input::Location location, string element, string tag
int row, TestLocation location, string element, string tag
) {
getQueryKind() = "path-problem" and
mainQueryResult(row, 4, location) and
@@ -778,7 +875,7 @@ module TestPostProcessing {
tag = getSinkTag(row)
}
private predicate hasAlert(int row, Input::Location location, string element, string tag) {
private predicate hasAlert(int row, TestLocation location, string element, string tag) {
getQueryKind() = ["problem", "path-problem"] and
mainQueryResult(row, 0, location) and
queryResults(mainResultSet(), row, 2, element) and
@@ -793,7 +890,7 @@ module TestPostProcessing {
* present).
*/
private string getValue(int row) {
exists(Input::Location location, string element, string tag, string val |
exists(TestLocation location, string element, string tag, string val |
hasPathProblemSource(row, location, element, tag, val) and
result =
PathProblemSourceTest::getAMatchingExpectation(location, element, tag, val, false)
@@ -801,7 +898,7 @@ module TestPostProcessing {
)
}
predicate hasActualResult(Input::Location location, string element, string tag, string value) {
predicate hasActualResult(TestLocation location, string element, string tag, string value) {
exists(int row |
hasPathProblemSource(row, location, element, tag, _)
or
@@ -840,7 +937,7 @@ module TestPostProcessing {
rankedTestFailures(row, f) and
f = MkTestFailure(fl, message)
|
column = 0 and data = Input2::getRelativeUrl(fl.getLocation())
column = 0 and data = fl.getLocation().getRelativeUrl()
or
column = 1 and data = fl.toString()
or