hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-21 15:05:56 +02:00
Code Issues Packages Projects Releases Wiki Activity

Swift: The regressed test is not realistic, update it to be more like what really happens.

Browse Source
This commit is contained in:
Geoffrey White
2023-03-21 11:07:36 +00:00
parent e266132f0a
commit 9529bc5f09
2 changed files with 10 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
swift/ql/test/query-tests/Security/CWE-135/StringLengthConflation.expected
View File

@@ -1,4 +1,5 @@
edges
| StringLengthConflation2.swift:35:36:35:38 | .count : | StringLengthConflation2.swift:35:36:35:46 | ... .-(_:_:) ... |
| StringLengthConflation2.swift:37:34:37:36 | .count : | StringLengthConflation2.swift:37:34:37:44 | ... .-(_:_:) ... |
| StringLengthConflation.swift:36:30:36:37 | len : | StringLengthConflation.swift:36:93:36:93 | len |
| StringLengthConflation.swift:60:47:60:50 | .length : | StringLengthConflation.swift:60:47:60:59 | ... ./(_:_:) ... |
@@ -27,6 +28,8 @@ edges
| file://:0:0:0:0 | .length : | StringLengthConflation.swift:114:23:114:26 | .length : |
| file://:0:0:0:0 | .length : | StringLengthConflation.swift:120:22:120:25 | .length : |
nodes
| StringLengthConflation2.swift:35:36:35:38 | .count : | semmle.label | .count : |
| StringLengthConflation2.swift:35:36:35:46 | ... .-(_:_:) ... | semmle.label | ... .-(_:_:) ... |
| StringLengthConflation2.swift:37:34:37:36 | .count : | semmle.label | .count : |
| StringLengthConflation2.swift:37:34:37:44 | ... .-(_:_:) ... | semmle.label | ... .-(_:_:) ... |
| StringLengthConflation.swift:36:30:36:37 | len : | semmle.label | len : |
@@ -76,6 +79,7 @@ nodes
| file://:0:0:0:0 | .length : | semmle.label | .length : |
subpaths
#select
| StringLengthConflation2.swift:35:36:35:46 | ... .-(_:_:) ... | StringLengthConflation2.swift:35:36:35:38 | .count : | StringLengthConflation2.swift:35:36:35:46 | ... .-(_:_:) ... | This String length is used in an NSString, but it may not be equivalent. |
| StringLengthConflation2.swift:37:34:37:44 | ... .-(_:_:) ... | StringLengthConflation2.swift:37:34:37:36 | .count : | StringLengthConflation2.swift:37:34:37:44 | ... .-(_:_:) ... | This String length is used in an NSString, but it may not be equivalent. |
| StringLengthConflation.swift:36:93:36:93 | len | StringLengthConflation.swift:72:33:72:35 | .count : | StringLengthConflation.swift:36:93:36:93 | len | This String length is used in an NSString, but it may not be equivalent. |
| StringLengthConflation.swift:53:43:53:46 | .length | StringLengthConflation.swift:53:43:53:46 | .length | StringLengthConflation.swift:53:43:53:46 | .length | This NSString length is used in a String, but it may not be equivalent. |

12
swift/ql/test/query-tests/Security/CWE-135/StringLengthConflation2.swift
View File

@@ -12,12 +12,7 @@ class NSObject
{
}
class NSStringBase : NSObject
{
func substring(from: Int) -> String { return "" }
}
class NSString : NSStringBase
class NSString : NSObject
{
init(string: String) { length = string.count }
@@ -26,6 +21,11 @@ class NSString : NSStringBase
private(set) var length: Int
}
extension NSString
{
func substring(from: Int) -> String { return "" }
}
// --- tests ---
func test(s: String) {