hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-24 08:15:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

Rust: Add explicit types in some (not all) of the test cases.

Browse Source
This commit is contained in:
Geoffrey White
2025-07-16 17:06:52 +01:00
parent 62b7d84638
commit 944fd2aa11
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
rust/ql/test/query-tests/security/CWE-089/sqlx.rs
View File

@@ -39,8 +39,8 @@ use sqlx::Executor;
async fn test_sqlx_mysql(url: &str, enable_remote: bool) -> Result<(), sqlx::Error> {
// connect through a MySQL connection pool
let pool = sqlx::mysql::MySqlPool::connect(url).await?;
let mut conn = pool.acquire().await?;
let pool: sqlx::Pool<sqlx::MySql> = sqlx::mysql::MySqlPool::connect(url).await?;
let mut conn: sqlx::pool::PoolConnection<sqlx::MySql> = pool.acquire().await?;
// construct queries (with extra variants)
let const_string = String::from("Alice");
@@ -61,7 +61,7 @@ async fn test_sqlx_mysql(url: &str, enable_remote: bool) -> Result<(), sqlx::Err
let prepared_query_1 = String::from("SELECT * FROM people WHERE firstname=?"); // (prepared arguments are safe)
// direct execution
let _ = conn.execute(safe_query_1.as_str()).await?; // $ MISSING: sql-sink
let _: sqlx::mysql::MySqlQueryResult = conn.execute(safe_query_1.as_str()).await?; // $ MISSING: sql-sink
let _ = conn.execute(safe_query_2.as_str()).await?; // $ MISSING: sql-sink
let _ = conn.execute(safe_query_3.as_str()).await?; // $ MISSING: sql-sink
let _ = conn.execute(unsafe_query_1.as_str()).await?; // $ MISSING: sql-sink Alert[rust/sql-injection]=args1