hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-03-30 20:28:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

Guards: Improve join-order.

Browse Source
This commit is contained in:
Anders Schack-Mulligen
2026-02-23 10:56:36 +01:00
parent 2b8e719034
commit 94121f19ca
1 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
shared/controlflow/codeql/controlflow/Guards.qll
View File

@@ -597,6 +597,12 @@ module Make<
module Logic<LogicInputSig LogicInput> {
private import LogicInput
bindingset[bb1, bb2]
pragma[inline_late]
private predicate strictlyDominatesCheck(BasicBlock bb1, BasicBlock bb2) {
bb1.strictlyDominates(bb2)
}
/**
* Holds if `guard` evaluating to `v` directly controls `phi` taking the value
* `inp`. This means that `guard` evaluating to `v` must control all the input
@@ -614,7 +620,7 @@ module Make<
exists(BasicBlock bbPhi |
phi.hasInputFromBlock(inp, _) and
phi.getBasicBlock() = bbPhi and
guard.getBasicBlock().strictlyDominates(bbPhi) and
strictlyDominatesCheck(guard.getBasicBlock(), bbPhi) and
not guard.directlyValueControls(bbPhi, _) and
forex(BasicBlock bbInput | phi.hasInputFromBlock(inp, bbInput) |
guard.directlyValueControls(bbInput, v) or