hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-01-29 22:32:58 +01:00
Code Issues Packages Projects Releases Wiki Activity

Address review comments.

Browse Source
This commit is contained in:
Sauyon Lee
2020-03-20 04:22:28 -07:00
parent fd88d913f7
commit 932840b0a3
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
ql/src/semmle/go/security/OpenUrlRedirect.qll
View File

@@ -82,17 +82,17 @@ module OpenUrlRedirect {
(frn.getFieldName() = "Host" or frn.getFieldName() = "Path")
)
or
exists(Write w, Field f, SsaWithFields v | f.hasQualifiedName("net/url", "URL", "Path") |
// propagate to a URL when its host is assigned to
exists(Write w, Field f, SsaWithFields v | f.hasQualifiedName("net/url", "URL", "Host") |
w.writesField(v.getAUse(), f, pred) and succ = v.getAUse()
)
}
override predicate isBarrierOut(DataFlow::Node node) {
exists(Write w, Field f | f.hasQualifiedName("net/url", "URL", "Path") |
// block propagation of this safe value when its host is overwritten
exists(Write w, Field f | f.hasQualifiedName("net/url", "URL", "Host") |
w.writesField(node.getASuccessor(), f, _)
)
}
override int explorationLimit() { result = 30 }
}
}