hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-30 03:05:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse Source 
Co-authored-by: Geoffrey White <40627776+geoffw0@users.noreply.github.com>
This commit is contained in:
ihsinme
2021-03-08 14:23:42 +03:00
committed by GitHub
parent 2b1b94835e
commit 921c41d710
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
cpp/ql/src/experimental/Security/CWE/CWE-020/LateCheckOfFunctionArgument.ql
View File

@@ -15,7 +15,7 @@
import cpp
import semmle.code.cpp.valuenumbering.GlobalValueNumbering
/ ** Pridekat allows you to get the number of the argument used for positioning in the buffer by the name of the function. * /
/** Holds for a function `f` that has an argument at index `apos` used for positioning in a buffer. */
predicate numberArgument(Function f, int apos) {
f.hasGlobalOrStdName("write") and apos = 2
or
@@ -54,7 +54,7 @@ class IfCompareWithZero extends IfStmt {
from FunctionCall fc, IfCompareWithZero ifc, int na
where
numberArgument(fc.getTarget(), na)
numberArgument(fc.getTarget(), na) and
globalValueNumber(fc.getArgument(na)) = globalValueNumber(ifc.noZerroOperand()) and
dominates(fc, ifc) and
not exists(IfStmt ifc1 |