hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-25 08:45:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

Apply review feedback: use Lazy<> instead of locking

Browse Source
This commit is contained in:
Tamas Vajk
2023-12-20 11:04:36 +01:00
parent dc36cdbede
commit 90fc54ca05
1 changed files with 11 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
csharp/extractor/Semmle.Util/FileUtils.cs
View File

@@ -144,40 +144,26 @@ namespace Semmle.Util
return nested;
}
private static string? tempFolderPath = null;
private static readonly object lockObject = new();
private static Lazy<string> tempFolderPath = new Lazy<string>(() =>
{
var tempPath = Path.GetTempPath();
var name = Guid.NewGuid().ToString("N").ToUpper();
var tempFolder = Path.Combine(tempPath, "GitHub", name);
Directory.CreateDirectory(tempFolder);
return tempFolder;
});
public static string GetTemporaryWorkingDirectory(Func<string, string?> getEnvironmentVariable, string lang, out bool shouldCleanUp)
{
shouldCleanUp = false;
var tempFolder = getEnvironmentVariable($"CODEQL_EXTRACTOR_{lang}_SCRATCH_DIR");
if (!string.IsNullOrEmpty(tempFolder))
{
shouldCleanUp = false;
return tempFolder;
}
if (!string.IsNullOrEmpty(tempFolderPath))
{
shouldCleanUp = true;
return tempFolderPath;
}
lock (lockObject)
{
if (!string.IsNullOrEmpty(tempFolderPath))
{
shouldCleanUp = true;
return tempFolderPath;
}
var tempPath = Path.GetTempPath();
var name = Guid.NewGuid().ToString("N").ToUpper();
tempFolder = Path.Combine(tempPath, "GitHub", name);
Directory.CreateDirectory(tempFolder);
tempFolderPath = tempFolder;
shouldCleanUp = true;
return tempFolder;
}
shouldCleanUp = true;
return tempFolderPath.Value;
}
public static string GetTemporaryWorkingDirectory(out bool shouldCleanUp) =>