hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2025-12-17 01:03:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #58 from xiemaisi/js/demote-heterogeneous-comparison

Browse Source 
Approved by asger-semmle
This commit is contained in:
semmle-qlci
2018-08-15 09:01:24 +01:00
committed by GitHub
parent 105b6c9d84 303b0a0027
commit 8e5059f43a
2 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
change-notes/1.18/analysis-javascript.md
View File

@@ -81,6 +81,7 @@
| **Query** | **Expected impact** | **Change** |
|----------------------------|------------------------|------------------------------------------------------------------|
| Arguments redefined | Fewer results | This rule previously also flagged redefinitions of `eval`. This was an oversight that is now fixed. |
| Comparison between inconvertible types | Lower severity | The severity of this rule has been revised to "warning". |
| CORS misconfiguration for credentials transfer | More true-positive results | This rule now treats header names case-insensitively. |
| Hard-coded credentials | More true-positive results | This rule now recognizes secret cryptographic keys. |
| Incomplete sanitization | More true-positive results | This rule now recognizes incomplete URL encoding and decoding. |

2
javascript/ql/src/Expressions/HeterogeneousComparison.ql
View File

@@ -4,7 +4,7 @@
* the same type will always yield 'false', and an inequality comparison will always
* yield 'true'.
* @kind problem
* @problem.severity error
* @problem.severity warning
* @id js/comparison-between-incompatible-types
* @tags reliability
* correctness