hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-26 09:15:12 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix generic type constraint stubbing on overrides

Browse Source
This commit is contained in:
Tamas Vajk
2021-04-16 14:05:39 +02:00
parent ff4db5b8d2
commit 8cbdd30e1e
1 changed files with 16 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
csharp/ql/src/Stubs/Stubs.qll
View File

@@ -433,10 +433,22 @@ private string stubConstraints(TypeParameterConstraints tpc) {
}
private string stubTypeParameterConstraints(TypeParameter tp) {
exists(TypeParameterConstraints tpc | tpc = tp.getConstraints() |
result =
" where " + tp.getName() + ": " + strictconcat(string s | s = stubConstraints(tpc) | s, ", ")
)
if
tp.getDeclaringGeneric().(Virtualizable).isOverride() or
tp.getDeclaringGeneric().(Virtualizable).implementsExplicitInterface()
then
if tp.getConstraints().hasValueTypeConstraint()
then result = " where " + tp.getName() + ": struct"
else
if tp.getConstraints().hasRefTypeConstraint()
then result = " where " + tp.getName() + ": class"
else result = ""
else
exists(TypeParameterConstraints tpc | tpc = tp.getConstraints() |
result =
" where " + tp.getName() + ": " +
strictconcat(string s | s = stubConstraints(tpc) | s, ", ")
)
}
private string stubTypeParametersConstraints(Declaration d) {