hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-29 18:55:14 +02:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #5947 from hvitved/csharp/encode-display-name

Browse Source 
C#: Encode `"` in `BuildDisplayName`
This commit is contained in:
Tom Hvitved
2021-05-25 10:58:31 +02:00
committed by GitHub
parent b33adb8630 2a33756bdf
commit 8cbb3caaa4
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
csharp/extractor/Semmle.Extraction.CSharp/SymbolExtensions.cs
View File

@@ -373,7 +373,7 @@ namespace Semmle.Extraction.CSharp
var elementType = array.ElementType;
if (elementType.MetadataName.Contains("`"))
{
trapFile.Write(elementType.Name);
trapFile.Write(TrapExtensions.EncodeString(elementType.Name));
return;
}
elementType.BuildDisplayName(cx, trapFile);
@@ -480,7 +480,7 @@ namespace Semmle.Extraction.CSharp
}
else
{
trapFile.Write(namedType.Name);
trapFile.Write(TrapExtensions.EncodeString(namedType.Name));
}
if (namedType.IsGenericType && namedType.TypeKind != TypeKind.Error && namedType.TypeArguments.Any())

2
csharp/extractor/Semmle.Extraction/TrapExtensions.cs
View File

@@ -117,7 +117,7 @@ namespace Semmle.Extraction
return s;
}
private static string EncodeString(string s) => s.Replace("\"", "\"\"");
public static string EncodeString(string s) => s.Replace("\"", "\"\"");
/// <summary>
/// Output a string to the trap file, such that the encoded output does not exceed