Merge pull request #19776 from Napalys/js/mass_quality_promotion

JS: Mass promotion of queries to `quality` status

javascript/ql/integration-tests/query-suite/javascript-code-quality-extended.qls.expected

@@ -1,9 +1,98 @@
+ql/javascript/ql/src/AngularJS/DependencyMismatch.ql
+ql/javascript/ql/src/AngularJS/DuplicateDependency.ql
+ql/javascript/ql/src/AngularJS/IncompatibleService.ql
+ql/javascript/ql/src/AngularJS/MissingExplicitInjection.ql
+ql/javascript/ql/src/AngularJS/RepeatedInjection.ql
+ql/javascript/ql/src/AngularJS/UseNgSrc.ql
+ql/javascript/ql/src/DOM/DuplicateAttributes.ql
+ql/javascript/ql/src/DOM/MalformedIdAttribute.ql
+ql/javascript/ql/src/DOM/PseudoEval.ql
+ql/javascript/ql/src/Declarations/ArgumentsRedefined.ql
+ql/javascript/ql/src/Declarations/AssignmentToConst.ql
+ql/javascript/ql/src/Declarations/ClobberingVarInit.ql
+ql/javascript/ql/src/Declarations/ConflictingFunctions.ql
+ql/javascript/ql/src/Declarations/DeadStoreOfLocal.ql
+ql/javascript/ql/src/Declarations/DeadStoreOfProperty.ql
+ql/javascript/ql/src/Declarations/DeclBeforeUse.ql
+ql/javascript/ql/src/Declarations/DefaultArgumentReferencesNestedFunction.ql
+ql/javascript/ql/src/Declarations/DuplicateVarDecl.ql
 ql/javascript/ql/src/Declarations/IneffectiveParameterType.ql
+ql/javascript/ql/src/Declarations/MissingThisQualifier.ql
+ql/javascript/ql/src/Declarations/MissingVarDecl.ql
+ql/javascript/ql/src/Declarations/MixedStaticInstanceThisAccess.ql
 ql/javascript/ql/src/Declarations/SuspiciousMethodNameDeclaration.ql
+ql/javascript/ql/src/Declarations/TemporalDeadZone.ql
+ql/javascript/ql/src/Declarations/UniqueParameterNames.ql
+ql/javascript/ql/src/Declarations/UniquePropertyNames.ql
+ql/javascript/ql/src/Declarations/UnreachableMethodOverloads.ql
+ql/javascript/ql/src/Declarations/UnusedVariable.ql
+ql/javascript/ql/src/Expressions/ComparisonWithNaN.ql
+ql/javascript/ql/src/Expressions/DuplicateCondition.ql
+ql/javascript/ql/src/Expressions/DuplicateProperty.ql
+ql/javascript/ql/src/Expressions/DuplicateSwitchCase.ql
 ql/javascript/ql/src/Expressions/ExprHasNoEffect.ql
+ql/javascript/ql/src/Expressions/HeterogeneousComparison.ql
+ql/javascript/ql/src/Expressions/ImplicitOperandConversion.ql
 ql/javascript/ql/src/Expressions/MissingAwait.ql
+ql/javascript/ql/src/Expressions/MissingDotLengthInComparison.ql
+ql/javascript/ql/src/Expressions/MissingSpaceInAppend.ql
+ql/javascript/ql/src/Expressions/MisspelledVariableName.ql
+ql/javascript/ql/src/Expressions/RedundantExpression.ql
+ql/javascript/ql/src/Expressions/SelfAssignment.ql
+ql/javascript/ql/src/Expressions/ShiftOutOfRange.ql
+ql/javascript/ql/src/Expressions/StringInsteadOfRegex.ql
+ql/javascript/ql/src/Expressions/SuspiciousInvocation.ql
+ql/javascript/ql/src/Expressions/SuspiciousPropAccess.ql
+ql/javascript/ql/src/Expressions/UnboundEventHandlerReceiver.ql
+ql/javascript/ql/src/Expressions/UnclearOperatorPrecedence.ql
+ql/javascript/ql/src/Expressions/UnknownDirective.ql
+ql/javascript/ql/src/Expressions/UnneededDefensiveProgramming.ql
+ql/javascript/ql/src/Expressions/WhitespaceContradictsPrecedence.ql
+ql/javascript/ql/src/LanguageFeatures/BadTypeof.ql
+ql/javascript/ql/src/LanguageFeatures/ConditionalComments.ql
+ql/javascript/ql/src/LanguageFeatures/DeleteVar.ql
+ql/javascript/ql/src/LanguageFeatures/ExpressionClosures.ql
+ql/javascript/ql/src/LanguageFeatures/ForInComprehensionBlocks.ql
+ql/javascript/ql/src/LanguageFeatures/IllegalInvocation.ql
+ql/javascript/ql/src/LanguageFeatures/InconsistentNew.ql
+ql/javascript/ql/src/LanguageFeatures/InvalidPrototype.ql
+ql/javascript/ql/src/LanguageFeatures/LengthComparisonOffByOne.ql
+ql/javascript/ql/src/LanguageFeatures/NonLinearPattern.ql
+ql/javascript/ql/src/LanguageFeatures/PropertyWriteOnPrimitive.ql
+ql/javascript/ql/src/LanguageFeatures/SemicolonInsertion.ql
+ql/javascript/ql/src/LanguageFeatures/SetterReturn.ql
 ql/javascript/ql/src/LanguageFeatures/SpuriousArguments.ql
+ql/javascript/ql/src/LanguageFeatures/StrictModeCallStackIntrospection.ql
+ql/javascript/ql/src/LanguageFeatures/SyntaxError.ql
 ql/javascript/ql/src/LanguageFeatures/TemplateSyntaxInStringLiteral.ql
+ql/javascript/ql/src/LanguageFeatures/ThisBeforeSuper.ql
+ql/javascript/ql/src/LanguageFeatures/UnusedIndexVariable.ql
+ql/javascript/ql/src/LanguageFeatures/WithStatement.ql
+ql/javascript/ql/src/LanguageFeatures/YieldInNonGenerator.ql
+ql/javascript/ql/src/NodeJS/InvalidExport.ql
+ql/javascript/ql/src/NodeJS/MissingExports.ql
 ql/javascript/ql/src/Quality/UnhandledErrorInStreamPipeline.ql
+ql/javascript/ql/src/React/DirectStateMutation.ql
+ql/javascript/ql/src/React/InconsistentStateUpdate.ql
+ql/javascript/ql/src/React/UnsupportedStateUpdateInLifecycleMethod.ql
+ql/javascript/ql/src/React/UnusedOrUndefinedStateProperty.ql
+ql/javascript/ql/src/RegExp/BackrefBeforeGroup.ql
+ql/javascript/ql/src/RegExp/BackrefIntoNegativeLookahead.ql
 ql/javascript/ql/src/RegExp/DuplicateCharacterInCharacterClass.ql
+ql/javascript/ql/src/RegExp/EmptyCharacterClass.ql
 ql/javascript/ql/src/RegExp/RegExpAlwaysMatches.ql
+ql/javascript/ql/src/RegExp/UnboundBackref.ql
+ql/javascript/ql/src/RegExp/UnmatchableCaret.ql
+ql/javascript/ql/src/RegExp/UnmatchableDollar.ql
+ql/javascript/ql/src/Statements/DanglingElse.ql
+ql/javascript/ql/src/Statements/IgnoreArrayResult.ql
+ql/javascript/ql/src/Statements/InconsistentLoopOrientation.ql
+ql/javascript/ql/src/Statements/LabelInCase.ql
+ql/javascript/ql/src/Statements/MisleadingIndentationAfterControlStmt.ql
+ql/javascript/ql/src/Statements/ReturnAssignsLocal.ql
+ql/javascript/ql/src/Statements/SuspiciousUnusedLoopIterationVariable.ql
+ql/javascript/ql/src/Statements/UnreachableStatement.ql
+ql/javascript/ql/src/Statements/UseOfReturnlessFunction.ql
+ql/javascript/ql/src/Statements/UselessComparisonTest.ql
+ql/javascript/ql/src/Statements/UselessConditional.ql
+ql/javascript/ql/src/Vue/ArrowMethodOnVueInstance.ql

javascript/ql/integration-tests/query-suite/javascript-code-quality.qls.expected

@@ -1,9 +1,98 @@
+ql/javascript/ql/src/AngularJS/DependencyMismatch.ql
+ql/javascript/ql/src/AngularJS/DuplicateDependency.ql
+ql/javascript/ql/src/AngularJS/IncompatibleService.ql
+ql/javascript/ql/src/AngularJS/MissingExplicitInjection.ql
+ql/javascript/ql/src/AngularJS/RepeatedInjection.ql
+ql/javascript/ql/src/AngularJS/UseNgSrc.ql
+ql/javascript/ql/src/DOM/DuplicateAttributes.ql
+ql/javascript/ql/src/DOM/MalformedIdAttribute.ql
+ql/javascript/ql/src/DOM/PseudoEval.ql
+ql/javascript/ql/src/Declarations/ArgumentsRedefined.ql
+ql/javascript/ql/src/Declarations/AssignmentToConst.ql
+ql/javascript/ql/src/Declarations/ClobberingVarInit.ql
+ql/javascript/ql/src/Declarations/ConflictingFunctions.ql
+ql/javascript/ql/src/Declarations/DeadStoreOfLocal.ql
+ql/javascript/ql/src/Declarations/DeadStoreOfProperty.ql
+ql/javascript/ql/src/Declarations/DeclBeforeUse.ql
+ql/javascript/ql/src/Declarations/DefaultArgumentReferencesNestedFunction.ql
+ql/javascript/ql/src/Declarations/DuplicateVarDecl.ql
 ql/javascript/ql/src/Declarations/IneffectiveParameterType.ql
+ql/javascript/ql/src/Declarations/MissingThisQualifier.ql
+ql/javascript/ql/src/Declarations/MissingVarDecl.ql
+ql/javascript/ql/src/Declarations/MixedStaticInstanceThisAccess.ql
 ql/javascript/ql/src/Declarations/SuspiciousMethodNameDeclaration.ql
+ql/javascript/ql/src/Declarations/TemporalDeadZone.ql
+ql/javascript/ql/src/Declarations/UniqueParameterNames.ql
+ql/javascript/ql/src/Declarations/UniquePropertyNames.ql
+ql/javascript/ql/src/Declarations/UnreachableMethodOverloads.ql
+ql/javascript/ql/src/Declarations/UnusedVariable.ql
+ql/javascript/ql/src/Expressions/ComparisonWithNaN.ql
+ql/javascript/ql/src/Expressions/DuplicateCondition.ql
+ql/javascript/ql/src/Expressions/DuplicateProperty.ql
+ql/javascript/ql/src/Expressions/DuplicateSwitchCase.ql
 ql/javascript/ql/src/Expressions/ExprHasNoEffect.ql
+ql/javascript/ql/src/Expressions/HeterogeneousComparison.ql
+ql/javascript/ql/src/Expressions/ImplicitOperandConversion.ql
 ql/javascript/ql/src/Expressions/MissingAwait.ql
+ql/javascript/ql/src/Expressions/MissingDotLengthInComparison.ql
+ql/javascript/ql/src/Expressions/MissingSpaceInAppend.ql
+ql/javascript/ql/src/Expressions/MisspelledVariableName.ql
+ql/javascript/ql/src/Expressions/RedundantExpression.ql
+ql/javascript/ql/src/Expressions/SelfAssignment.ql
+ql/javascript/ql/src/Expressions/ShiftOutOfRange.ql
+ql/javascript/ql/src/Expressions/StringInsteadOfRegex.ql
+ql/javascript/ql/src/Expressions/SuspiciousInvocation.ql
+ql/javascript/ql/src/Expressions/SuspiciousPropAccess.ql
+ql/javascript/ql/src/Expressions/UnboundEventHandlerReceiver.ql
+ql/javascript/ql/src/Expressions/UnclearOperatorPrecedence.ql
+ql/javascript/ql/src/Expressions/UnknownDirective.ql
+ql/javascript/ql/src/Expressions/UnneededDefensiveProgramming.ql
+ql/javascript/ql/src/Expressions/WhitespaceContradictsPrecedence.ql
+ql/javascript/ql/src/LanguageFeatures/BadTypeof.ql
+ql/javascript/ql/src/LanguageFeatures/ConditionalComments.ql
+ql/javascript/ql/src/LanguageFeatures/DeleteVar.ql
+ql/javascript/ql/src/LanguageFeatures/ExpressionClosures.ql
+ql/javascript/ql/src/LanguageFeatures/ForInComprehensionBlocks.ql
+ql/javascript/ql/src/LanguageFeatures/IllegalInvocation.ql
+ql/javascript/ql/src/LanguageFeatures/InconsistentNew.ql
+ql/javascript/ql/src/LanguageFeatures/InvalidPrototype.ql
+ql/javascript/ql/src/LanguageFeatures/LengthComparisonOffByOne.ql
+ql/javascript/ql/src/LanguageFeatures/NonLinearPattern.ql
+ql/javascript/ql/src/LanguageFeatures/PropertyWriteOnPrimitive.ql
+ql/javascript/ql/src/LanguageFeatures/SemicolonInsertion.ql
+ql/javascript/ql/src/LanguageFeatures/SetterReturn.ql
 ql/javascript/ql/src/LanguageFeatures/SpuriousArguments.ql
+ql/javascript/ql/src/LanguageFeatures/StrictModeCallStackIntrospection.ql
+ql/javascript/ql/src/LanguageFeatures/SyntaxError.ql
 ql/javascript/ql/src/LanguageFeatures/TemplateSyntaxInStringLiteral.ql
+ql/javascript/ql/src/LanguageFeatures/ThisBeforeSuper.ql
+ql/javascript/ql/src/LanguageFeatures/UnusedIndexVariable.ql
+ql/javascript/ql/src/LanguageFeatures/WithStatement.ql
+ql/javascript/ql/src/LanguageFeatures/YieldInNonGenerator.ql
+ql/javascript/ql/src/NodeJS/InvalidExport.ql
+ql/javascript/ql/src/NodeJS/MissingExports.ql
 ql/javascript/ql/src/Quality/UnhandledErrorInStreamPipeline.ql
+ql/javascript/ql/src/React/DirectStateMutation.ql
+ql/javascript/ql/src/React/InconsistentStateUpdate.ql
+ql/javascript/ql/src/React/UnsupportedStateUpdateInLifecycleMethod.ql
+ql/javascript/ql/src/React/UnusedOrUndefinedStateProperty.ql
+ql/javascript/ql/src/RegExp/BackrefBeforeGroup.ql
+ql/javascript/ql/src/RegExp/BackrefIntoNegativeLookahead.ql
 ql/javascript/ql/src/RegExp/DuplicateCharacterInCharacterClass.ql
+ql/javascript/ql/src/RegExp/EmptyCharacterClass.ql
 ql/javascript/ql/src/RegExp/RegExpAlwaysMatches.ql
+ql/javascript/ql/src/RegExp/UnboundBackref.ql
+ql/javascript/ql/src/RegExp/UnmatchableCaret.ql
+ql/javascript/ql/src/RegExp/UnmatchableDollar.ql
+ql/javascript/ql/src/Statements/DanglingElse.ql
+ql/javascript/ql/src/Statements/IgnoreArrayResult.ql
+ql/javascript/ql/src/Statements/InconsistentLoopOrientation.ql
+ql/javascript/ql/src/Statements/LabelInCase.ql
+ql/javascript/ql/src/Statements/MisleadingIndentationAfterControlStmt.ql
+ql/javascript/ql/src/Statements/ReturnAssignsLocal.ql
+ql/javascript/ql/src/Statements/SuspiciousUnusedLoopIterationVariable.ql
+ql/javascript/ql/src/Statements/UnreachableStatement.ql
+ql/javascript/ql/src/Statements/UseOfReturnlessFunction.ql
+ql/javascript/ql/src/Statements/UselessComparisonTest.ql
+ql/javascript/ql/src/Statements/UselessConditional.ql
+ql/javascript/ql/src/Vue/ArrowMethodOnVueInstance.ql

javascript/ql/src/AngularJS/DependencyMismatch.ql

@@ -7,8 +7,9 @@
  * @problem.severity warning
  * @precision very-high
  * @id js/angular/dependency-injection-mismatch
- * @tags correctness
- *       maintainability
+ * @tags quality
+ *       reliability
+ *       correctness
  *       frameworks/angularjs
  */
 

javascript/ql/src/AngularJS/DuplicateDependency.ql

@@ -5,7 +5,9 @@
  * @problem.severity warning
  * @precision very-high
  * @id js/angular/duplicate-dependency
- * @tags maintainability
+ * @tags quality
+ *       maintainability
+ *       readability
  *       frameworks/angularjs
  */
 

javascript/ql/src/AngularJS/IncompatibleService.ql

@@ -5,7 +5,9 @@
  * @problem.severity error
  * @precision high
  * @id js/angular/incompatible-service
- * @tags correctness
+ * @tags quality
+ *       reliability
+ *       correctness
  *       frameworks/angularjs
  */
 

javascript/ql/src/AngularJS/MissingExplicitInjection.ql

@@ -6,8 +6,9 @@
  * @problem.severity warning
  * @precision high
  * @id js/angular/missing-explicit-injection
- * @tags correctness
- *         maintainability
+ * @tags quality
+ *       reliability
+ *       correctness
  *       frameworks/angularjs
  */
 

javascript/ql/src/AngularJS/RepeatedInjection.ql

@@ -5,7 +5,9 @@
  * @problem.severity warning
  * @precision high
  * @id js/angular/repeated-dependency-injection
- * @tags maintainability
+ * @tags quality
+ *       maintainability
+ *       readability
  *       frameworks/angularjs
  */
 

javascript/ql/src/AngularJS/UseNgSrc.ql

@@ -7,7 +7,9 @@
  * @problem.severity warning
  * @precision very-high
  * @id js/angular/expression-in-url-attribute
- * @tags maintainability
+ * @tags quality
+ *       reliability
+ *       correctness
  *       frameworks/angularjs
  */
 

javascript/ql/src/DOM/DuplicateAttributes.ql

@@ -5,7 +5,8 @@
  * @kind problem
  * @problem.severity warning
  * @id js/duplicate-html-attribute
- * @tags maintainability
+ * @tags quality
+ *       maintainability
  *       readability
  * @precision very-high
  */

javascript/ql/src/DOM/MalformedIdAttribute.ql

@@ -5,7 +5,8 @@
  * @kind problem
  * @problem.severity warning
  * @id js/malformed-html-id
- * @tags maintainability
+ * @tags quality
+ *       reliability
  *       correctness
  *       external/cwe/cwe-758
  * @precision very-high

javascript/ql/src/DOM/PseudoEval.ql

@@ -5,7 +5,9 @@
  * @kind problem
  * @problem.severity recommendation
  * @id js/eval-like-call
- * @tags maintainability
+ * @tags quality
+ *       maintainability
+ *       readability
  *       external/cwe/cwe-676
  * @precision very-high
  */

javascript/ql/src/Declarations/ArgumentsRedefined.ql

@@ -6,8 +6,9 @@
  * @kind problem
  * @problem.severity recommendation
  * @id js/arguments-redefinition
- * @tags efficiency
- *       maintainability
+ * @tags quality
+ *       reliability
+ *       performance
  * @precision very-high
  */
 

javascript/ql/src/Declarations/AssignmentToConst.ql

@@ -5,7 +5,8 @@
  * @kind problem
  * @problem.severity error
  * @id js/assignment-to-constant
- * @tags reliability
+ * @tags quality
+ *       reliability
  *       correctness
  * @precision very-high
  */

javascript/ql/src/Declarations/ClobberingVarInit.ql

@@ -5,7 +5,8 @@
  * @kind problem
  * @problem.severity error
  * @id js/variable-initialization-conflict
- * @tags reliability
+ * @tags quality
+ *       reliability
  *       correctness
  *       external/cwe/cwe-563
  * @precision very-high

javascript/ql/src/Declarations/ConflictingFunctions.ql

@@ -6,7 +6,8 @@
  * @kind problem
  * @problem.severity error
  * @id js/function-declaration-conflict
- * @tags reliability
+ * @tags quality
+ *       reliability
  *       correctness
  *       external/cwe/cwe-563
  * @precision high

javascript/ql/src/Declarations/DeadStoreOfLocal.ql

@@ -5,7 +5,9 @@
  * @kind problem
  * @problem.severity warning
  * @id js/useless-assignment-to-local
- * @tags maintainability
+ * @tags quality
+ *       maintainability
+ *       useless-code
  *       external/cwe/cwe-563
  * @precision very-high
  */

javascript/ql/src/Declarations/DeadStoreOfProperty.ql

@@ -4,7 +4,9 @@
  * @kind problem
  * @problem.severity warning
  * @id js/useless-assignment-to-property
- * @tags maintainability
+ * @tags quality
+ *       maintainability
+ *       useless-code
  * @precision high
  */
 

javascript/ql/src/Declarations/DeclBeforeUse.ql

@@ -4,7 +4,8 @@
  * @kind problem
  * @problem.severity warning
  * @id js/use-before-declaration
- * @tags maintainability
+ * @tags quality
+ *       maintainability
  *       readability
  * @precision very-high
  */

javascript/ql/src/Declarations/DefaultArgumentReferencesNestedFunction.ql

@@ -6,7 +6,8 @@
  * @kind problem
  * @problem.severity error
  * @id js/nested-function-reference-in-default-parameter
- * @tags reliability
+ * @tags quality
+ *       reliability
  *       correctness
  * @precision very-high
  */

javascript/ql/src/Declarations/DuplicateVarDecl.ql

@@ -5,7 +5,9 @@
  * @kind problem
  * @problem.severity recommendation
  * @id js/duplicate-variable-declaration
- * @tags maintainability
+ * @tags quality
+ *       maintainability
+ *       readability
  * @precision very-high
  */
 

javascript/ql/src/Declarations/IneffectiveParameterType.ql

@@ -5,9 +5,10 @@
  * @problem.severity warning
  * @id js/ineffective-parameter-type
  * @precision high
- * @tags correctness
+ * @tags quality
+ *       reliability
+ *       correctness
  *       typescript
- *       quality
  */
 
 import javascript

javascript/ql/src/Declarations/MissingThisQualifier.ql

@@ -4,7 +4,8 @@
  * @kind problem
  * @problem.severity error
  * @id js/missing-this-qualifier
- * @tags maintainability
+ * @tags quality
+ *       reliability
  *       correctness
  *       methods
  * @precision high

javascript/ql/src/Declarations/MissingVarDecl.ql

@@ -5,8 +5,9 @@
  * @kind problem
  * @problem.severity warning
  * @id js/missing-variable-declaration
- * @tags reliability
- *       maintainability
+ * @tags quality
+ *       reliability
+ *       correctness
  * @precision high
  */
 

javascript/ql/src/Declarations/MixedStaticInstanceThisAccess.ql

@@ -4,7 +4,9 @@
  * @kind problem
  * @problem.severity error
  * @id js/mixed-static-instance-this-access
- * @tags correctness
+ * @tags quality
+ *       reliability
+ *       correctness
  *       methods
  * @precision high
  */

javascript/ql/src/Declarations/TemporalDeadZone.ql

@@ -5,8 +5,10 @@
  * @kind problem
  * @problem.severity error
  * @id js/variable-use-in-temporal-dead-zone
- * @tags portability
+ * @tags quality
+ *       reliability
  *       correctness
+ *       portability
  * @precision very-high
  */
 

javascript/ql/src/Declarations/UniqueParameterNames.ql

@@ -5,7 +5,8 @@
  * @kind problem
  * @problem.severity error
  * @id js/duplicate-parameter-name
- * @tags reliability
+ * @tags quality
+ *       reliability
  *       correctness
  * @precision very-high
  */

javascript/ql/src/Declarations/UniquePropertyNames.ql

@@ -6,7 +6,8 @@
  * @kind problem
  * @problem.severity error
  * @id js/overwritten-property
- * @tags reliability
+ * @tags quality
+ *       reliability
  *       correctness
  *       external/cwe/cwe-563
  * @precision very-high

javascript/ql/src/Declarations/UnreachableMethodOverloads.ql

@@ -7,7 +7,9 @@
  * @problem.severity warning
  * @id js/unreachable-method-overloads
  * @precision high
- * @tags correctness
+ * @tags quality
+ *       reliability
+ *       correctness
  *       typescript
  */
 

javascript/ql/src/Declarations/UnusedVariable.ql

@@ -5,7 +5,9 @@
  * @kind problem
  * @problem.severity recommendation
  * @id js/unused-local-variable
- * @tags maintainability
+ * @tags quality
+ *       maintainability
+ *       useless-code
  * @precision very-high
  */
 

javascript/ql/src/Expressions/ComparisonWithNaN.ql

@@ -5,7 +5,8 @@
  * @kind problem
  * @problem.severity error
  * @id js/comparison-with-nan
- * @tags reliability
+ * @tags quality
+ *       reliability
  *       correctness
  *       external/cwe/cwe-570
  *       external/cwe/cwe-571

javascript/ql/src/Expressions/DuplicateCondition.ql

@@ -5,7 +5,8 @@
  * @kind problem
  * @problem.severity warning
  * @id js/duplicate-condition
- * @tags maintainability
+ * @tags quality
+ *       reliability
  *       correctness
  *       external/cwe/cwe-561
  * @precision very-high

javascript/ql/src/Expressions/DuplicateProperty.ql

@@ -5,7 +5,9 @@
  * @kind problem
  * @problem.severity warning
  * @id js/duplicate-property
- * @tags maintainability
+ * @tags quality
+ *       maintainability
+ *       readability
  *       external/cwe/cwe-563
  * @precision very-high
  */

javascript/ql/src/Expressions/DuplicateSwitchCase.ql

@@ -5,7 +5,8 @@
  * @kind problem
  * @problem.severity warning
  * @id js/duplicate-switch-case
- * @tags maintainability
+ * @tags quality
+ *       reliability
  *       correctness
  *       external/cwe/cwe-561
  * @precision very-high

javascript/ql/src/Expressions/ExprHasNoEffect.ql

@@ -7,10 +7,9 @@
  * @id js/useless-expression
  * @tags quality
  *       maintainability
- *       correctness
+ *       useless-code
  *       external/cwe/cwe-480
  *       external/cwe/cwe-561
- *       useless-code
  * @precision very-high
  */
 

javascript/ql/src/Expressions/HeterogeneousComparison.ql

@@ -6,7 +6,8 @@
  * @kind problem
  * @problem.severity warning
  * @id js/comparison-between-incompatible-types
- * @tags reliability
+ * @tags quality
+ *       reliability
  *       correctness
  *       external/cwe/cwe-570
  *       external/cwe/cwe-571

javascript/ql/src/Expressions/ImplicitOperandConversion.ql

@@ -5,8 +5,9 @@
  * @kind problem
  * @problem.severity warning
  * @id js/implicit-operand-conversion
- * @tags reliability
- *       readability
+ * @tags quality
+ *       reliability
+ *       correctness
  *       external/cwe/cwe-704
  * @precision very-high
  */

javascript/ql/src/Expressions/MissingAwait.ql

@@ -4,8 +4,9 @@
  * @kind problem
  * @problem.severity warning
  * @id js/missing-await
- * @tags correctness
- *       quality
+ * @tags quality
+ *       reliability
+ *       correctness
  * @precision high
  */
 

javascript/ql/src/Expressions/MissingDotLengthInComparison.ql

@@ -6,7 +6,9 @@
  * @problem.severity warning
  * @id js/missing-dot-length-in-comparison
  * @precision high
- * @tags correctness
+ * @tags quality
+ *       reliability
+ *       correctness
  */
 
 import javascript

javascript/ql/src/Expressions/MissingSpaceInAppend.ql

@@ -7,7 +7,9 @@
  * @problem.severity warning
  * @precision very-high
  * @id js/missing-space-in-concatenation
- * @tags readability
+ * @tags quality
+ *       maintainability
+ *       readability
  */
 
 import javascript

javascript/ql/src/Expressions/MisspelledVariableName.ql

@@ -6,8 +6,8 @@
  * @kind problem
  * @problem.severity warning
  * @id js/misspelled-variable-name
- * @tags maintainability
- *       readability
+ * @tags quality
+ *       reliability
  *       correctness
  * @precision very-high
  */

javascript/ql/src/Expressions/RedundantExpression.ql

@@ -6,7 +6,8 @@
  * @kind problem
  * @problem.severity warning
  * @id js/redundant-operation
- * @tags reliability
+ * @tags quality
+ *       reliability
  *       correctness
  *       external/cwe/cwe-480
  *       external/cwe/cwe-561

javascript/ql/src/Expressions/SelfAssignment.ql

@@ -4,7 +4,8 @@
  * @kind problem
  * @problem.severity warning
  * @id js/redundant-assignment
- * @tags reliability
+ * @tags quality
+ *       reliability
  *       correctness
  *       external/cwe/cwe-480
  *       external/cwe/cwe-561

javascript/ql/src/Expressions/ShiftOutOfRange.ql

@@ -5,7 +5,8 @@
  * @kind problem
  * @problem.severity error
  * @id js/shift-out-of-range
- * @tags reliability
+ * @tags quality
+ *       reliability
  *       correctness
  *       external/cwe/cwe-197
  * @precision very-high

javascript/ql/src/Expressions/StringInsteadOfRegex.ql

@@ -4,7 +4,9 @@
  * @kind problem
  * @problem.severity warning
  * @id js/string-instead-of-regex
- * @tags correctness
+ * @tags quality
+ *       reliability
+ *       correctness
  * @precision high
  */
 

javascript/ql/src/Expressions/SuspiciousInvocation.ql

@@ -5,7 +5,9 @@
  * @kind problem
  * @problem.severity error
  * @id js/call-to-non-callable
- * @tags correctness
+ * @tags quality
+ *       reliability
+ *       correctness
  *       external/cwe/cwe-476
  * @precision high
  */

javascript/ql/src/Expressions/SuspiciousPropAccess.ql

@@ -5,7 +5,9 @@
  * @kind problem
  * @problem.severity error
  * @id js/property-access-on-non-object
- * @tags correctness
+ * @tags quality
+ *       reliability
+ *       correctness
  *       external/cwe/cwe-476
  * @precision high
  */

javascript/ql/src/Expressions/UnboundEventHandlerReceiver.ql

@@ -4,7 +4,9 @@
  * @kind problem
  * @problem.severity error
  * @id js/unbound-event-handler-receiver
- * @tags correctness
+ * @tags quality
+ *       reliability
+ *       correctness
  * @precision high
  */
 

javascript/ql/src/Expressions/UnclearOperatorPrecedence.ql

@@ -5,8 +5,9 @@
  * @kind problem
  * @problem.severity recommendation
  * @id js/unclear-operator-precedence
- * @tags maintainability
- *       correctness
+ * @tags quality
+ *       maintainability
+ *       readability
  *       statistical
  *       non-attributable
  *       external/cwe/cwe-783

javascript/ql/src/Expressions/UnknownDirective.ql

@@ -4,7 +4,9 @@
  * @kind problem
  * @problem.severity warning
  * @id js/unknown-directive
- * @tags correctness
+ * @tags quality
+ *       reliability
+ *       correctness
  * @precision high
  */
 

javascript/ql/src/Expressions/UnneededDefensiveProgramming.ql

@@ -4,7 +4,9 @@
  * @kind problem
  * @problem.severity recommendation
  * @id js/unneeded-defensive-code
- * @tags correctness
+ * @tags quality
+ *       maintainability
+ *       useless-code
  *       external/cwe/cwe-570
  *       external/cwe/cwe-571
  * @precision very-high

javascript/ql/src/Expressions/WhitespaceContradictsPrecedence.ql

@@ -5,7 +5,8 @@
  * @kind problem
  * @problem.severity warning
  * @id js/whitespace-contradicts-precedence
- * @tags maintainability
+ * @tags quality
+ *       reliability
  *       correctness
  *       statistical
  *       non-attributable

javascript/ql/src/LanguageFeatures/BadTypeof.ql

@@ -6,7 +6,8 @@
  * @kind problem
  * @problem.severity error
  * @id js/useless-type-test
- * @tags maintainability
+ * @tags quality
+ *       reliability
  *       correctness
  *       language-features
  *       external/cwe/cwe-570

javascript/ql/src/LanguageFeatures/ConditionalComments.ql

@@ -4,8 +4,10 @@
  * @kind problem
  * @problem.severity warning
  * @id js/conditional-comment
- * @tags portability
- *       maintainability
+ * @tags quality
+ *       reliability
+ *       correctness
+ *       portability
  *       language-features
  *       external/cwe/cwe-758
  * @precision very-high

javascript/ql/src/LanguageFeatures/DeleteVar.ql

@@ -4,8 +4,9 @@
  * @kind problem
  * @problem.severity warning
  * @id js/deletion-of-non-property
- * @tags reliability
- *       maintainability
+ * @tags quality
+ *       reliability
+ *       correctness
  *       language-features
  *       external/cwe/cwe-480
  * @precision very-high

javascript/ql/src/LanguageFeatures/ExpressionClosures.ql

@@ -5,8 +5,10 @@
  * @kind problem
  * @problem.severity warning
  * @id js/non-standard-language-feature
- * @tags portability
+ * @tags quality
  *       maintainability
+ *       readability
+ *       portability
  *       language-features
  *       external/cwe/cwe-758
  * @precision very-high

javascript/ql/src/LanguageFeatures/ForInComprehensionBlocks.ql

@@ -5,8 +5,10 @@
  * @kind problem
  * @problem.severity error
  * @id js/for-in-comprehension
- * @tags portability
+ * @tags quality
  *       maintainability
+ *       readability
+ *       portability
  *       language-features
  *       external/cwe/cwe-758
  * @precision very-high

javascript/ql/src/LanguageFeatures/IllegalInvocation.ql

@@ -6,7 +6,9 @@
  * @kind problem
  * @problem.severity error
  * @id js/illegal-invocation
- * @tags correctness
+ * @tags quality
+ *       reliability
+ *       correctness
  *       language-features
  * @precision high
  */

javascript/ql/src/LanguageFeatures/InconsistentNew.ql

@@ -6,7 +6,8 @@
  * @kind problem
  * @problem.severity warning
  * @id js/inconsistent-use-of-new
- * @tags reliability
+ * @tags quality
+ *       reliability
  *       correctness
  *       language-features
  * @precision very-high

javascript/ql/src/LanguageFeatures/InvalidPrototype.ql

@@ -5,7 +5,9 @@
  * @kind problem
  * @problem.severity error
  * @id js/invalid-prototype-value
- * @tags correctness
+ * @tags quality
+ *       reliability
+ *       correctness
  *       language-features
  *       external/cwe/cwe-704
  * @precision high

javascript/ql/src/LanguageFeatures/LengthComparisonOffByOne.ql

@@ -5,9 +5,11 @@
  * @kind problem
  * @problem.severity warning
  * @id js/index-out-of-bounds
- * @tags reliability
+ * @tags quality
+ *       reliability
  *       correctness
  *       logic
+ *       language-features
  *       external/cwe/cwe-193
  * @precision high
  */

javascript/ql/src/LanguageFeatures/NonLinearPattern.ql

@@ -6,7 +6,8 @@
  * @kind problem
  * @problem.severity error
  * @id js/non-linear-pattern
- * @tags reliability
+ * @tags quality
+ *       reliability
  *       correctness
  *       language-features
  * @precision very-high

javascript/ql/src/LanguageFeatures/PropertyWriteOnPrimitive.ql

@@ -5,7 +5,9 @@
  * @kind problem
  * @problem.severity error
  * @id js/property-assignment-on-primitive
- * @tags correctness
+ * @tags quality
+ *       reliability
+ *       correctness
  *       language-features
  *       external/cwe/cwe-704
  * @precision high

javascript/ql/src/LanguageFeatures/SemicolonInsertion.ql

@@ -4,7 +4,9 @@
  * @kind problem
  * @problem.severity recommendation
  * @id js/automatic-semicolon-insertion
- * @tags maintainability
+ * @tags quality
+ *       maintainability
+ *       readability
  *       language-features
  *       statistical
  *       non-attributable

javascript/ql/src/LanguageFeatures/SetterReturn.ql

@@ -5,7 +5,9 @@
  * @kind problem
  * @problem.severity warning
  * @id js/setter-return
- * @tags maintainability
+ * @tags quality
+ *       maintainability
+ *       useless-code
  *       language-features
  * @precision very-high
  */

javascript/ql/src/LanguageFeatures/SpuriousArguments.ql

@@ -4,10 +4,10 @@
  * @kind problem
  * @problem.severity warning
  * @id js/superfluous-trailing-arguments
- * @tags maintainability
+ * @tags quality
+ *       reliability
  *       correctness
  *       language-features
- *       quality
  *       external/cwe/cwe-685
  * @precision very-high
  */

javascript/ql/src/LanguageFeatures/StrictModeCallStackIntrospection.ql

@@ -6,7 +6,9 @@
  * @kind problem
  * @problem.severity error
  * @id js/strict-mode-call-stack-introspection
- * @tags correctness
+ * @tags quality
+ *       reliability
+ *       correctness
  *       language-features
  * @precision high
  */

javascript/ql/src/LanguageFeatures/SyntaxError.ql

@@ -4,7 +4,8 @@
  * @kind problem
  * @problem.severity recommendation
  * @id js/syntax-error
- * @tags reliability
+ * @tags quality
+ *       reliability
  *       correctness
  *       language-features
  * @precision very-high

javascript/ql/src/LanguageFeatures/ThisBeforeSuper.ql

@@ -5,7 +5,9 @@
  * @kind problem
  * @problem.severity error
  * @id js/incomplete-object-initialization
- * @tags correctness
+ * @tags quality
+ *       reliability
+ *       correctness
  *       language-features
  * @precision high
  */

javascript/ql/src/LanguageFeatures/UnusedIndexVariable.ql

@@ -6,7 +6,9 @@
  * @problem.severity warning
  * @id js/unused-index-variable
  * @precision high
- * @tags correctness
+ * @tags quality
+ *       reliability
+ *       correctness
  */
 
 import javascript

javascript/ql/src/LanguageFeatures/WithStatement.ql

@@ -4,7 +4,9 @@
  * @kind problem
  * @problem.severity warning
  * @id js/with-statement
- * @tags maintainability
+ * @tags quality
+ *       maintainability
+ *       complexity
  *       language-features
  * @precision very-high
  */

javascript/ql/src/LanguageFeatures/YieldInNonGenerator.ql

@@ -4,7 +4,9 @@
  * @kind problem
  * @problem.severity error
  * @id js/yield-outside-generator
- * @tags maintainability
+ * @tags quality
+ *       reliability
+ *       correctness
  *       language-features
  *       external/cwe/cwe-758
  * @precision very-high

javascript/ql/src/NodeJS/InvalidExport.ql

@@ -5,7 +5,9 @@
  * @kind problem
  * @problem.severity warning
  * @id js/node/assignment-to-exports-variable
- * @tags maintainability
+ * @tags quality
+ *       reliability
+ *       correctness
  *       frameworks/node.js
  *       external/cwe/cwe-563
  * @precision very-high

javascript/ql/src/NodeJS/MissingExports.ql

@@ -5,7 +5,9 @@
  * @kind problem
  * @problem.severity error
  * @id js/node/missing-exports-qualifier
- * @tags maintainability
+ * @tags quality
+ *       reliability
+ *       correctness
  *       frameworks/node.js
  * @precision high
  */

javascript/ql/src/React/DirectStateMutation.ql

@@ -5,7 +5,9 @@
  * @kind problem
  * @problem.severity warning
  * @id js/react/direct-state-mutation
- * @tags reliability
+ * @tags quality
+ *       reliability
+ *       correctness
  *       frameworks/react
  * @precision very-high
  */

javascript/ql/src/React/InconsistentStateUpdate.ql

@@ -6,7 +6,9 @@
  * @kind problem
  * @problem.severity warning
  * @id js/react/inconsistent-state-update
- * @tags reliability
+ * @tags quality
+ *       reliability
+ *       correctness
  *       frameworks/react
  * @precision very-high
  */

javascript/ql/src/React/UnsupportedStateUpdateInLifecycleMethod.ql

@@ -4,7 +4,9 @@
  * @kind problem
  * @problem.severity warning
  * @id js/react/unsupported-state-update-in-lifecycle-method
- * @tags reliability
+ * @tags quality
+ *       reliability
+ *       correctness
  *       frameworks/react
  * @precision high
  */

javascript/ql/src/React/UnusedOrUndefinedStateProperty.ql

@@ -4,8 +4,9 @@
  * @kind problem
  * @problem.severity warning
  * @id js/react/unused-or-undefined-state-property
- * @tags correctness
+ * @tags quality
  *       reliability
+ *       correctness
  *       frameworks/react
  * @precision high
  */

javascript/ql/src/RegExp/BackrefBeforeGroup.ql

@@ -5,7 +5,8 @@
  * @kind problem
  * @problem.severity error
  * @id js/regex/back-reference-before-group
- * @tags reliability
+ * @tags quality
+ *       reliability
  *       correctness
  *       regular-expressions
  * @precision very-high

javascript/ql/src/RegExp/BackrefIntoNegativeLookahead.ql

@@ -5,7 +5,8 @@
  * @kind problem
  * @problem.severity error
  * @id js/regex/back-reference-to-negative-lookahead
- * @tags reliability
+ * @tags quality
+ *       reliability
  *       correctness
  *       regular-expressions
  * @precision very-high

javascript/ql/src/RegExp/EmptyCharacterClass.ql

@@ -4,7 +4,8 @@
  * @kind problem
  * @problem.severity warning
  * @id js/regex/empty-character-class
- * @tags reliability
+ * @tags quality
+ *       reliability
  *       correctness
  *       regular-expressions
  * @precision very-high

javascript/ql/src/RegExp/RegExpAlwaysMatches.ql

@@ -4,9 +4,10 @@
  * @kind problem
  * @problem.severity warning
  * @id js/regex/always-matches
- * @tags correctness
+ * @tags quality
+ *       reliability
+ *       correctness
  *       regular-expressions
- *       quality
  * @precision high
  */
 

javascript/ql/src/RegExp/UnboundBackref.ql

@@ -6,7 +6,8 @@
  * @kind problem
  * @problem.severity warning
  * @id js/regex/unbound-back-reference
- * @tags reliability
+ * @tags quality
+ *       reliability
  *       correctness
  *       regular-expressions
  * @precision very-high

javascript/ql/src/RegExp/UnmatchableCaret.ql

@@ -6,7 +6,8 @@
  * @kind problem
  * @problem.severity error
  * @id js/regex/unmatchable-caret
- * @tags reliability
+ * @tags quality
+ *       reliability
  *       correctness
  *       regular-expressions
  *       external/cwe/cwe-561

javascript/ql/src/RegExp/UnmatchableDollar.ql

@@ -6,7 +6,8 @@
  * @kind problem
  * @problem.severity error
  * @id js/regex/unmatchable-dollar
- * @tags reliability
+ * @tags quality
+ *       reliability
  *       correctness
  *       regular-expressions
  *       external/cwe/cwe-561

javascript/ql/src/Statements/DanglingElse.ql

@@ -4,7 +4,9 @@
  * @kind problem
  * @problem.severity warning
  * @id js/misleading-indentation-of-dangling-else
- * @tags readability
+ * @tags quality
+ *       maintainability
+ *       readability
  *       statistical
  *       non-attributable
  *       external/cwe/cwe-483

javascript/ql/src/Statements/IgnoreArrayResult.ql

@@ -4,7 +4,8 @@
  * @kind problem
  * @problem.severity warning
  * @id js/ignore-array-result
- * @tags maintainability
+ * @tags quality
+ *       reliability
  *       correctness
  * @precision high
  */

javascript/ql/src/Statements/InconsistentLoopOrientation.ql

@@ -8,7 +8,9 @@
  * @kind problem
  * @problem.severity error
  * @id js/inconsistent-loop-direction
- * @tags correctness
+ * @tags quality
+ *       reliability
+ *       correctness
  *       external/cwe/cwe-835
  * @precision very-high
  */

javascript/ql/src/Statements/LabelInCase.ql

@@ -5,8 +5,9 @@
  * @kind problem
  * @problem.severity warning
  * @id js/label-in-switch
- * @tags reliability
- *       readability
+ * @tags quality
+ *       reliability
+ *       correctness
  * @precision very-high
  */
 

javascript/ql/src/Statements/MisleadingIndentationAfterControlStmt.ql

@@ -5,7 +5,9 @@
  * @kind problem
  * @problem.severity warning
  * @id js/misleading-indentation-after-control-statement
- * @tags correctness
+ * @tags quality
+ *       maintainability
+ *       readability
  *       statistical
  *       non-attributable
  *       external/cwe/cwe-483

javascript/ql/src/Statements/ReturnAssignsLocal.ql

@@ -5,8 +5,9 @@
  * @kind problem
  * @problem.severity warning
  * @id js/useless-assignment-in-return
- * @tags maintainability
- *       readability
+ * @tags quality
+ *       reliability
+ *       correctness
  *       external/cwe/cwe-563
  * @precision very-high
  */

javascript/ql/src/Statements/SuspiciousUnusedLoopIterationVariable.ql

@@ -4,7 +4,8 @@
  * @kind problem
  * @problem.severity error
  * @id js/unused-loop-variable
- * @tags maintainability
+ * @tags quality
+ *       reliability
  *       correctness
  * @precision high
  */

javascript/ql/src/Statements/UnreachableStatement.ql

@@ -4,7 +4,8 @@
  * @kind problem
  * @problem.severity warning
  * @id js/unreachable-statement
- * @tags maintainability
+ * @tags quality
+ *       reliability
  *       correctness
  *       external/cwe/cwe-561
  * @precision very-high

javascript/ql/src/Statements/UseOfReturnlessFunction.ql

@@ -4,7 +4,8 @@
  * @kind problem
  * @problem.severity warning
  * @id js/use-of-returnless-function
- * @tags maintainability
+ * @tags quality
+ *       reliability
  *       correctness
  * @precision high
  */

javascript/ql/src/Statements/UselessComparisonTest.ql

@@ -5,7 +5,9 @@
  * @kind problem
  * @problem.severity warning
  * @id js/useless-comparison-test
- * @tags correctness
+ * @tags quality
+ *       reliability
+ *       correctness
  * @precision high
  */
 

javascript/ql/src/Statements/UselessConditional.ql

@@ -6,7 +6,9 @@
  * @kind problem
  * @problem.severity warning
  * @id js/trivial-conditional
- * @tags correctness
+ * @tags quality
+ *       reliability
+ *       correctness
  *       external/cwe/cwe-570
  *       external/cwe/cwe-571
  * @precision very-high

javascript/ql/src/Vue/ArrowMethodOnVueInstance.ql

@@ -4,7 +4,9 @@
  * @kind problem
  * @problem.severity warning
  * @id js/vue/arrow-method-on-vue-instance
- * @tags reliability
+ * @tags quality
+ *       reliability
+ *       correctness
  *       frameworks/vue
  * @precision high
  */

javascript/ql/src/change-notes/2025-06-16-mass-promotion.md

@@ -0,0 +1,4 @@
+---
+category: queryMetadata
+---
+* The `quality` tag has been added to multiple JavaScript quality queries, with tags for `reliability` or `maintainability` categories and their sub-categories. See [Query file metadata and alert message style guide](https://github.com/github/codeql/blob/main/docs/query-metadata-style-guide.md#quality-query-sub-category-tags) for more information about these categories.