hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-03 04:39:29 +02:00
Code Issues Packages Projects Releases Wiki Activity

C#: Address review comments.

Browse Source
This commit is contained in:
calum
2018-10-19 18:08:52 +01:00
parent 5a4af0c2b2
commit 8c29d0eb0a
1 changed files with 6 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
csharp/ql/src/Concurrency/LockOrder.ql
View File

@@ -14,17 +14,15 @@
import csharp
/**
* Find a call target conservatively only when there is
* a static target or one runtime target.
* Gets a call target conservatively only when there is
* one runtime target.
*/
Callable getCallTarget(Call c) {
if count(c.getARuntimeTarget()) = 1 then
result = c.getARuntimeTarget()
else
result = c.getTarget()
count(c.getARuntimeTarget()) = 1 and
result = c.getARuntimeTarget()
}
/** Find any lock statement reachable from a callable. */
/** Gets a lock statement reachable from a callable. */
LockStmt getAReachableLockStmt(Callable callable) {
result.getEnclosingCallable() = callable
or
@@ -34,7 +32,7 @@ LockStmt getAReachableLockStmt(Callable callable) {
}
/**
* Finds nested pairs of lock statements, either
* Holds if there is nested pairs of lock statements, either
* inter-procedurally or intra-procedurally.
*/
predicate nestedLocks(Variable outerVariable, Variable innerVariable, LockStmt outer, LockStmt inner) {