hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-05-05 13:45:19 +02:00
Code Issues Packages Projects Releases Wiki Activity

Change predicate name from getX to getOrder

Browse Source
This commit is contained in:
Owen Mansel-Chan
2023-10-27 09:48:51 +01:00
parent b451adabfc
commit 8beacb8d4a
1 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
go/ql/lib/semmle/go/security/IncorrectIntegerConversionLib.qll
View File

@@ -3,10 +3,11 @@ import go
/** The constant `math.MaxInt` or the constant `math.MaxUint`. */
abstract private class MaxIntOrMaxUint extends DeclaredConstant {
/**
* Gets the integer `x` such that `2.pow(x) - 1` is the value of this
* constant when the architecture has bit size `architectureBitSize`.
* Gets the (binary) order of magnitude when the architecture has bit size
* `architectureBitSize`, which is defined to be the integer `x` such that
* `2.pow(x) - 1` is the value of this constant.
*/
abstract int getX(int architectureBitSize);
abstract int getOrder(int architectureBitSize);
/**
* Holds if the value of this constant given `architectureBitSize` minus
@@ -15,7 +16,7 @@ abstract private class MaxIntOrMaxUint extends DeclaredConstant {
predicate isBoundFor(int b, int architectureBitSize, float strictnessOffset) {
// 2.pow(x) - 1 - strictnessOffset <= 2.pow(b) - 1
exists(int x |
x = this.getX(architectureBitSize) and
x = this.getOrder(architectureBitSize) and
b = validBitSize() and
(
strictnessOffset = 0 and x <= b
@@ -30,7 +31,7 @@ abstract private class MaxIntOrMaxUint extends DeclaredConstant {
private class MaxInt extends MaxIntOrMaxUint {
MaxInt() { this.hasQualifiedName("math", "MaxInt") }
override int getX(int architectureBitSize) {
override int getOrder(int architectureBitSize) {
architectureBitSize = [32, 64] and result = architectureBitSize - 1
}
}
@@ -39,7 +40,7 @@ private class MaxInt extends MaxIntOrMaxUint {
private class MaxUint extends MaxIntOrMaxUint {
MaxUint() { this.hasQualifiedName("math", "MaxUint") }
override int getX(int architectureBitSize) {
override int getOrder(int architectureBitSize) {
architectureBitSize = [32, 64] and result = architectureBitSize
}
}