hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-26 09:15:12 +02:00
Code Issues Packages Projects Releases Wiki Activity

Change how we deal with singular/plural

Browse Source
This commit is contained in:
Owen Mansel-Chan
2023-06-23 06:53:01 +01:00
parent 6eda207997
commit 8726b3a00e
1 changed files with 13 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
go/extractor/diagnostics/diagnostics.go
View File

@@ -129,16 +129,19 @@ func EmitPackageDifferentOSArchitecture(pkgPath string) {
)
}
func plural(n int, singular, plural string) string {
if n == 1 {
return singular
} else {
return plural
}
}
const maxNumPkgPaths = 5
func EmitCannotFindPackages(pkgPaths []string) {
numPkgPaths := len(pkgPaths)
ending := "s"
if numPkgPaths == 1 {
ending = ""
}
numPrinted := numPkgPaths
truncated := false
if numPrinted > maxNumPkgPaths {
@@ -154,7 +157,11 @@ func EmitCannotFindPackages(pkgPaths []string) {
emitDiagnostic(
"go/autobuilder/package-not-found",
"Some packages could not be found",
fmt.Sprintf("%d package%s could not be found:\n\n%s.\n\nDefinitions in those packages may not be recognized by CodeQL, and files that use them may only be partially analyzed.\n\nCheck that the paths are correct and make sure any private packages can be accessed. If any of the packages are present in the repository then you may need a [custom build command](https://docs.github.com/en/code-security/code-scanning/automatically-scanning-your-code-for-vulnerabilities-and-errors/configuring-the-codeql-workflow-for-compiled-languages).", numPkgPaths, ending, secondLine),
fmt.Sprintf(
"%d package%s could not be found:\n\n%s.\n\nDefinitions in those packages may not be recognized by CodeQL, and files that use them may only be partially analyzed.\n\nCheck that the paths are correct and make sure any private packages can be accessed. If any of the packages are present in the repository then you may need a [custom build command](https://docs.github.com/en/code-security/code-scanning/automatically-scanning-your-code-for-vulnerabilities-and-errors/configuring-the-codeql-workflow-for-compiled-languages).",
numPkgPaths,
plural(len(pkgPaths), "", "s"),
secondLine),
severityWarning,
fullVisibility,
noLocation,