hohn/codeql
1
0
Fork 0
mirror of https://github.com/github/codeql.git synced 2026-04-24 16:25:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

Swift: preload extension indexes

Browse Source 
Finding each extension declaration separately within its parent seemed
to create an `O(n^2)` noticeable performance problem. This is solved
by preloading indexes and storing them in a map, so as to iterate
through the parent of an extension only once per parent instead of once
per extension.
This commit is contained in:
Paolo Tranquilli
2023-03-27 16:55:48 +02:00
parent 146591934a
commit 826d7c7dbe
2 changed files with 27 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
swift/extractor/mangler/SwiftMangler.cpp
View File

@@ -98,26 +98,36 @@ SwiftMangledName SwiftMangler::visitExtensionDecl(const swift::ExtensionDecl* de
}
auto parent = getParent(decl);
unsigned index = 0;
return initMangled(decl) << fetch(parent) << getExtensionIndex(decl, parent);
}
unsigned SwiftMangler::getExtensionIndex(const swift::ExtensionDecl* decl,
const swift::Decl* parent) {
if (auto found = preloadedExtensionIndexes.extract(decl)) {
return found.mapped();
}
if (auto parentModule = llvm::dyn_cast<swift::ModuleDecl>(parent)) {
llvm::SmallVector<swift::Decl*> parentDecls;
parentModule->getTopLevelDecls(parentDecls);
auto found = std::find(std::begin(parentDecls), std::end(parentDecls), decl);
assert(found != std::end(parentDecls));
index = found - std::begin(parentDecls);
llvm::SmallVector<swift::Decl*> siblings;
parentModule->getTopLevelDecls(siblings);
indexExtensions(siblings);
} else if (auto iterableParent = llvm::dyn_cast<swift::IterableDeclContext>(parent)) {
auto parentDecls = iterableParent->getAllMembers();
auto found = std::find(std::begin(parentDecls), std::end(parentDecls), decl);
assert(found != std::end(parentDecls));
index = found - std::begin(parentDecls);
indexExtensions(iterableParent->getAllMembers());
} else {
assert(false && "non-local context must be module or iterable decl context");
}
auto found = preloadedExtensionIndexes.extract(decl);
assert(found && "extension not found within parent");
return found.mapped();
}
auto ret = initMangled(decl);
ret << fetch(parent);
ret << index;
return ret;
void SwiftMangler::indexExtensions(llvm::ArrayRef<swift::Decl*> siblings) {
auto index = 0u;
for (auto sibling : siblings) {
if (sibling->getKind() == swift::DeclKind::Extension) {
preloadedExtensionIndexes.emplace(sibling, index);
}
++index;
}
}
SwiftMangledName SwiftMangler::visitGenericTypeDecl(const swift::GenericTypeDecl* decl) {

3
swift/extractor/mangler/SwiftMangler.h
View File

@@ -102,6 +102,9 @@ class SwiftMangler : private swift::TypeVisitor<SwiftMangler, SwiftMangledName>,
swift::Mangle::ASTMangler mangler;
SwiftDispatcher& dispatcher;
std::unordered_map<const swift::Decl*, unsigned> preloadedExtensionIndexes;
void indexExtensions(llvm::ArrayRef<swift::Decl*> siblings);
unsigned int getExtensionIndex(const swift::ExtensionDecl* decl, const swift::Decl* parent);
};
} // namespace codeql